Improve error message when using build modes and autobuild fails#2206
Merged
henrymercer merged 2 commits intoMar 20, 2024
maingithub/codeql-action:mainfrom
henrymercer/improved-autobuild-error-with-build-modesgithub/codeql-action:henrymercer/improved-autobuild-error-with-build-modesCopy head branch name to clipboard
Merged
Improve error message when using build modes and autobuild fails#2206henrymercer merged 2 commits intomaingithub/codeql-action:mainfrom henrymercer/improved-autobuild-error-with-build-modesgithub/codeql-action:henrymercer/improved-autobuild-error-with-build-modesCopy head branch name to clipboard
henrymercer merged 2 commits into
maingithub/codeql-action:mainfrom
henrymercer/improved-autobuild-error-with-build-modesgithub/codeql-action:henrymercer/improved-autobuild-error-with-build-modesCopy head branch name to clipboard
Conversation
angelapwen
approved these changes
Mar 20, 2024
angelapwen
left a comment
Contributor
There was a problem hiding this comment.
Sounds good re. wrapping all CLI invocations 👍
This was referenced Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include a more specific error message tailored to the CodeQL Action.
Also wrap configuration errors in all CLI invocations, since the patterns we've specified in
cli-errors.tsare specific enough that to be applied to all CLI invocations without creating false negative failures.Merge / deployment checklist