Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add build mode, Actions event name, and languages to the status report#2170

Merged
henrymercer merged 6 commits into
maingithub/codeql-action:mainfrom
henrymercer/status-report-new-fieldsgithub/codeql-action:henrymercer/status-report-new-fieldsCopy head branch name to clipboard
Feb 27, 2024
Merged

Add build mode, Actions event name, and languages to the status report#2170
henrymercer merged 6 commits into
maingithub/codeql-action:mainfrom
henrymercer/status-report-new-fieldsgithub/codeql-action:henrymercer/status-report-new-fieldsCopy head branch name to clipboard

Conversation

@henrymercer

@henrymercer henrymercer commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

This PR adds the build mode and Actions event name to the status report. We also record the languages for all first-party Actions rather than just init so that we can more easily use this for incident response.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner February 26, 2024 19:38
Comment thread src/status-report.ts
*/
job_run_uuid: string;
/**
* Comma-separated list of languages that analysis was run for.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're now sending space-separated list rather than comma-separated: is that intentional? 👀

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch, agreed we should be sending comma-separated for consistency.

@henrymercer henrymercer added the Rebuild Re-transpile JS & re-generate workflows label Feb 27, 2024
We can't use the "Rebuild" label on a PR with conflicts because the
`pull_request` event runs on a synthetic merge commit.
@henrymercer henrymercer removed the Rebuild Re-transpile JS & re-generate workflows label Feb 27, 2024

@angelapwen angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@henrymercer henrymercer merged commit cc3808e into main Feb 27, 2024
@henrymercer henrymercer deleted the henrymercer/status-report-new-fields branch February 27, 2024 12:55
@github-actions github-actions Bot mentioned this pull request Feb 29, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.