Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Expand file tree

/

ComplexCondition.ql

Copy path
More file actions
More file actions

Latest commit

 

History

History
History
33 lines (29 loc) · 953 Bytes
/

ComplexCondition.ql

Copy path

File metadata and controls

33 lines (29 loc) · 953 Bytes
Raw
Copy raw file
Download raw file
Open symbols panel
Edit and raw actions
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
/**
* @name Complex condition
* @description Boolean expressions that are too deeply nested are hard to read and understand. Consider naming intermediate results as local variables.
* @kind problem
* @problem.severity recommendation
* @precision high
* @id cpp/complex-condition
* @tags testability
* readability
* maintainability
* statistical
* non-attributable
*/
import cpp
predicate logicalOp(string op) { op = "&&" or op = "||" }
predicate nontrivialLogicalOperator(Operation e) {
exists(string op |
op = e.getOperator() and
logicalOp(op) and
not op = e.getParent().(Operation).getOperator()
) and
not e.isInMacroExpansion()
}
from Expr e, int operators
where
not e.getParent() instanceof Expr and
operators = count(Operation op | op.getParent*() = e and nontrivialLogicalOperator(op)) and
operators > 5
select e, "Complex condition: too many logical operations in this expression."
Morty Proxy This is a proxified and sanitized view of the page, visit original site.