This repository was archived by the owner on Oct 21, 2021. It is now read-only.
Check html language#10
Open
Muhnad wants to merge 2 commits into
github:maingithub/accessibilityjs:mainfrom
Muhnad:feature/html-langCopy head branch name to clipboard
Open
Check html language#10Muhnad wants to merge 2 commits intogithub:maingithub/accessibilityjs:mainfrom Muhnad:feature/html-langCopy head branch name to clipboard
Muhnad wants to merge 2 commits into
github:maingithub/accessibilityjs:mainfrom
Muhnad:feature/html-langCopy head branch name to clipboard
Conversation
lodenrogue
approved these changes
Oct 18, 2017
|
Don't forget to add your error on the list in the README file. |
muan
suggested changes
Nov 13, 2017
muan
left a comment
Contributor
There was a problem hiding this comment.
There are linters set up in this repository now. Would you also merge master to make sure they passes with the requested changes? Thanks! 🙏🏻
| @@ -1,4 +1,10 @@ | ||
| export function scanForProblems(context, logError, options) { | ||
| for (const html of document.querySelectorAll('html')) { |
Contributor
There was a problem hiding this comment.
We should query on context not document. Also since html should be the root element, we should look upwards instead of downwards and assume there is only one html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.