Support alternate config dir for GitGitGadget#165
Merged
dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom Dec 9, 2019
Merged
Support alternate config dir for GitGitGadget#165dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
Conversation
Positioning change for tests which need to provide a separate config to GitGitGadget.get(). Currently, the current directory is passed. This will remain the default but user testing should not need to update the local repo config. This change will allow tests to provide an alternate location of the config which GitGitGadget uses to obtain SMTP information. Signed-off-by: Chris. Webster <chris@webstech.net>
dscho
approved these changes
Dec 9, 2019
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Positioning change for tests which need to provide a separate
config to GitGitGadget.get(). Currently, the current directory
is passed. This will remain the default but user testing should
not need to update the local repo config. This change will allow
tests to provide an alternate location of the config which
GitGitGadget uses to obtain SMTP information.
Issue #140 and PR #156 will be able to use this change. A work in progress at webstech/ci-helper-test is a sample use of this change.