Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Configuration Problem Testing CIHelper #140

Copy link
Copy link
@webstech

Description

@webstech
Issue body actions

CIHelper expects to be in the gitgitgadget repo so it can reference the res/Welcome.MD file. When testing, the workdir for CIHelper needs to point to different locations so the tests can run in parallel and the git config can be set outside of the tester's personal config.

In CIHelper, when creating a GitGitGadget, it is done with GitGitGadget.get("."). The get method will query the config for gitgitgadget.workDir using the passed '.' directory (IOW, the git config for gitgitgadget).

  1. This seems awkward because the CIHelper workdir is supposed to point to a git repository. Why not just pass that to GitGitGadget.get()?
  2. The get method is using the passed directory to obtain git config info. Is this supposed to be part of the git repo config or the gitgitgadget repo config? The get method does support two directories being passed.
  3. Concurrent testing has problems with different tests setting gitgitgadget.workDir. This can be worked around by changing directories to a different git config but that also requires copying res/Welcome.MD.

Hopefully this makes some sense. One solution is to provide CIHelper with a git repo (as is done now), and a location to get the config info (default to '.').

Questions? Other suggestions? Have I misunderstood everything?

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.