Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

build with go 1.21 and update dependencies#1427

Merged
hiddeco merged 1 commit into
getsops:maingetsops/sops:mainfrom
b-dean:go-1.21-update-depsb-dean/sops:go-1.21-update-depsCopy head branch name to clipboard
Feb 15, 2024
Merged

build with go 1.21 and update dependencies#1427
hiddeco merged 1 commit into
getsops:maingetsops/sops:mainfrom
b-dean:go-1.21-update-depsb-dean/sops:go-1.21-update-depsCopy head branch name to clipboard

Conversation

@b-dean

@b-dean b-dean commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

also run go get -u ./... to update all the dependencies

in particular, this fixes these vulnerabilities that show up in our scans:

Component Version Vulnerability Severity
github.com/cloudflare/circl v1.3.3 GHSA-9763-4f94-gfch high
go 1.20.8 CVE-2023-45285 high
go 1.20.8 CVE-2023-45283 high
go 1.20.8 CVE-2023-39325 high
go 1.20.8 CVE-2023-39323 high

@b-dean
b-dean force-pushed the go-1.21-update-deps branch from 9ffd771 to 2422c97 Compare February 1, 2024 20:20
@hiddeco

hiddeco commented Feb 6, 2024

Copy link
Copy Markdown
Member

Can you please rebase this so we can get the Go 1.21 update in? The dependency updates should have been dealt with due to me merging the outstanding Dependabot PRs. Thanks 🍒

@b-dean
b-dean force-pushed the go-1.21-update-deps branch from 2422c97 to 7589158 Compare February 6, 2024 15:46
@hiddeco

hiddeco commented Feb 9, 2024

Copy link
Copy Markdown
Member

Please run make vendor and amend to your commit. This should make CI pass.

also run `go get -u ./...` to update all the dependencies

Signed-off-by: Ben Dean <ben.dean@finvi.com>
@b-dean
b-dean force-pushed the go-1.21-update-deps branch from 7589158 to 12756c8 Compare February 13, 2024 19:56
@b-dean

b-dean commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

@hiddeco, should be good

@hiddeco hiddeco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @b-dean 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.