fix(v8/angular): Fall back to element tagName when name is not provided to TraceDirective#14828
Merged
Lms24 merged 2 commits intov8getsentry/sentry-javascript:v8from Dec 23, 2024
lms/fix-angular-backport-14778getsentry/sentry-javascript:lms/fix-angular-backport-14778Copy head branch name to clipboard
Merged
fix(v8/angular): Fall back to element tagName when name is not provided to TraceDirective#14828Lms24 merged 2 commits intov8getsentry/sentry-javascript:v8from lms/fix-angular-backport-14778getsentry/sentry-javascript:lms/fix-angular-backport-14778Copy head branch name to clipboard
tagName when name is not provided to TraceDirective#14828Lms24 merged 2 commits intov8getsentry/sentry-javascript:v8from
lms/fix-angular-backport-14778getsentry/sentry-javascript:lms/fix-angular-backport-14778Copy head branch name to clipboard
Conversation
…d to `TraceDirective` (#14778) The `trace` directive should typically be declared on components to validly trace the lifecycle (from `ngOnInit` to `ngAfterViewInit`, when child views are also rendered). If `trace` is mistakenly not provided, we fall back to `tagName` instead of "unknown component". --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
andreiborza
approved these changes
Dec 23, 2024
This was referenced Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14778