feat(v8/react): Add a handled prop to ErrorBoundary#14978
Merged
Lms24 merged 2 commits intov8getsentry/sentry-javascript:v8from Jan 10, 2025
lms/feat-react-handled-prop-v8getsentry/sentry-javascript:lms/feat-react-handled-prop-v8Copy head branch name to clipboard
Merged
feat(v8/react): Add a handled prop to ErrorBoundary#14978Lms24 merged 2 commits intov8getsentry/sentry-javascript:v8from lms/feat-react-handled-prop-v8getsentry/sentry-javascript:lms/feat-react-handled-prop-v8Copy head branch name to clipboard
handled prop to ErrorBoundary#14978Lms24 merged 2 commits intov8getsentry/sentry-javascript:v8from
lms/feat-react-handled-prop-v8getsentry/sentry-javascript:lms/feat-react-handled-prop-v8Copy head branch name to clipboard
Conversation
The previous behaviour was to rely on the presence of the `fallback` prop to decide if the error was considered handled or not. The new property lets users explicitly choose what should the handled status be. If omitted, the old behaviour is still applied.
lforst
approved these changes
Jan 10, 2025
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #14560