Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jul 24, 2025

📜 Description

  • Refactors the integrations that subscribe for Lifecycle updates
    • There's only one callback registered in AppState now, upon initializing the SDK
    • The callback then is multi-casted to the internal listeners
    • It maintains the old behaviour where addObserver call would catch the new observer up to the current lifecycle state
  • Simplified SystemEventBreadcrumbsIntegration by removing a few unnecessary locks and calling unregisterReceiver from a background thread because it also does an IPC call

💡 Motivation and Context

easier to maintain SDK

💚 How did you test it?

manually + automated

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Use this new lifecycle approach to register/unregister NetworkCallback

Copy link
Contributor

github-actions bot commented Jul 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 442.20 ms 493.50 ms 51.30 ms
Size 1.58 MiB 2.09 MiB 521.81 KiB

Previous results on branch: rz/perf/single-lifecycle-observer

Startup times

Revision Plain With Sentry Diff
985e191 381.06 ms 407.08 ms 26.02 ms
8926466 426.41 ms 462.50 ms 36.09 ms
6fd675a 403.43 ms 446.55 ms 43.13 ms

App size

Revision Plain With Sentry Diff
985e191 1.58 MiB 2.09 MiB 521.14 KiB
8926466 1.58 MiB 2.09 MiB 521.82 KiB
6fd675a 1.58 MiB 2.09 MiB 521.12 KiB

Base automatically changed from rz/perf/single-network-callback to main August 1, 2025 13:29
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've proposed a few minor PR improvements on top over there, but not necessary for merging this already.

cursor[bot]

This comment was marked as outdated.

@romtsn romtsn enabled auto-merge (squash) August 5, 2025 09:24
@romtsn romtsn merged commit d0e5fdc into main Aug 5, 2025
35 of 36 checks passed
@romtsn romtsn deleted the rz/perf/single-lifecycle-observer branch August 5, 2025 09:34
adinauer pushed a commit that referenced this pull request Aug 8, 2025
* perf(connectivity): Cache network capabilities and status to reduce IPC calls

* changelog

* Changelog

* revert

* fix(breadcrumbs): Deduplicate battery breadcrumbs

* ref

* Changelog

* Fix test

* perf(connectivity): Have only one NetworkCallback active at a time

* Changelog

* perf(integrations): Use single lifecycle observer

* Add tests

* Changelog

* Fix tests

* Improve callback handling and test visibility (#4593)

* Null-check lifecycleObserver

---------

Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
adinauer added a commit that referenced this pull request Aug 8, 2025
* Do not report cached events as lost

* E2E tests for OpenTelemetry based console sample (#4563)

* e2e tests for console app

* fix test failures by waiting for 10s after first try to find envelopes

* add system-test-runner.py script to replace bash scripts for running e2e / system tests

* use py script for ci, cleanup, makefile

* Format code

* remove bash scripts

* install requests module

* api

* fix gh script

* Implement E2E tests for OTel based console sample

* fixes after merge

* Format code

* e2e tests for console app

* Implement E2E tests for OTel based console sample

* fixes after merge

* Format code

* api

* Reduce scope forking when using OpenTelemetry (#4565)

* Reduce scope forking in OpenTelemetry

* Format code

* api

* changelog

---------

Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>

* SDKs send queue is no longer shutdown immediately on re-init (#4564)

* Let queue drain on a restart

* Format code

* Format code

* Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt

* Let queue drain on a restart

* Format code

* Format code

* Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt

* adapt tests

* changelog

---------

Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>

---------

Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>

* release: 8.18.0

* ref(replay): Use main thread to schedule capture (#4542)

* perf(connectivity): Cache network capabilities and status to reduce IPC calls (#4560)

* fix(breadcrumbs): Deduplicate battery breadcrumbs (#4561)

* fix(ci): remove obsolete NDK debug symbols (#4581)

As they don't exist anymore and this is done within sentry-native directly: https://github.com/getsentry/sentry-native/pull/1327/files

* fix(android): Remove unused method (#4585)

* fix(android): Remove unused method

* Update Changelog

* Add rules file for documenting SDK offline behaviour (#4572)

#skip-changelog

## 📜 Description
<!--- Describe your changes in detail -->
Add rules file for documenting SDK offline behaviour

## 💡 Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Should help speed up AI reasoning about the SDK offline/retry behaviour.

## 💚 How did you test it?


## 📝 Checklist
<!--- Put an `x` in the boxes that apply -->

- [ ] I added tests to verify the changes.
- [ ] No new PII added or SDK only sends newly added PII if `sendDefaultPII` is enabled.
- [ ] I updated the docs if needed.
- [ ] I updated the wizard if needed.
- [ ] Review from the native team if needed.
- [ ] No breaking change or entry added to the changelog.
- [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.


## 🔮 Next steps

* perf(connectivity): Have only one NetworkCallback active at a time (#4562)

* fix(scripts): update-gradle script set-version (#4591)

* fix: sentry-android-ndk proguard rule keeps all native class (#4427)

* fix: sentry-androi-ndk proguard rule keeps all native class

* docs: update CHANGELOG

* fix: update CHANGELOG

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Markus Hintersteiner <m.hintersteiner@gmail.com>
Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>

* refactor(lifecycle): Use single lifecycle observer (#4567)

* perf(connectivity): Cache network capabilities and status to reduce IPC calls

* changelog

* Changelog

* revert

* fix(breadcrumbs): Deduplicate battery breadcrumbs

* ref

* Changelog

* Fix test

* perf(connectivity): Have only one NetworkCallback active at a time

* Changelog

* perf(integrations): Use single lifecycle observer

* Add tests

* Changelog

* Fix tests

* Improve callback handling and test visibility (#4593)

* Null-check lifecycleObserver

---------

Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>

* fix(sqlite): Fix abstract method error (#4597)

* fix(sqlite): Fix abstract method error

* Update CHANGELOG.md

* Suppress metadata version checks

* perf(integrations): Do not register for SystemEvents and NetworkCallbacks when launched with background importance (#4579)

* fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread (#4582)

* fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread

* Fix race conditions

* Update Changelog

* Update CHANGELOG.md

* Address PR feedback

* perf(executor): Prewarm SentryExecutorService (#4606)

* review feedback

* changelog

* pass through whether cache stored in AndroidEnvelopeCache + test

* Format code

---------

Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
Co-authored-by: getsentry-bot <bot@sentry.io>
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
Co-authored-by: Ghasem Shirdel <shirdelghasem79@gmail.com>
Co-authored-by: Markus Hintersteiner <m.hintersteiner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.