perf(connectivity): Cache network capabilities and status to reduce IPC calls #4560

romtsn · Jul 16, 2025

📜 Description

Register network callback on a bg thread upon AndroidConnectionStatusProvider instantiation
Cache latest available NetworkCapabilities for 2 minutes
Use the capabilities to determine the current network status and type
- If it's not available (cache expired), we'd fallback to retrieving it proactively and caching it
- pre-API-23 we'd be always querying it, but it's a very small number of devices
onLost/onUnavailable would immediately send DISCONNECTED now as opposed to retrieving connectionStatus again
Implement a isSignificantChange check, because onNetworkCapabilitiesChanged can be called many times due to bandwidth change/etc. and we're only interested in transport/connectivity changes
Unregister the network callback when the SDK is closing
Cache ConnectivityManager instance too (it should be safe to cache once per process as it's not dependant on any particular Context)

Ran a test with perfetto to count the number of binder calls, and these are the results:

Send app to background
Freeze it
Turn wifi on and off 5 times,
Unfreeze it back

Before (83 binder calls from SentryExecService)

After (5 binder calls from SentryExecService)

💡 Motivation and Context

Fixes #4200

💚 How did you test it?

Manually + automated

📝 Checklist

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Refactor NetworkBreadcrumbsIntegration so we register only one callback in AndroidConnectionStatusProvider and multiplex it
Register/unregister connectivity callback in foreground/background similar to SystemEvents integration

…PC calls

romtsn · Jul 16, 2025

...core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java

        }
+        lastCacheUpdateTime = timeProvider.getCurrentTimeMillis();
+
+        options


could drop this log call, but I thought it might be very useful to investigate potential issues. Under the hood getConnectionStatus and getConnectionType are very lightweight for a cache NetworkCapabilities instance, they just do bitmask operations to get the transport and capability

github-actions · Jul 16, 2025

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	321.63 ms	369.32 ms	47.69 ms
Size	1.58 MiB	2.09 MiB	521.11 KiB

Previous results on branch: rz/perf/less-ipc

Startup times

Revision	Plain	With Sentry	Diff
`6ef06c6`	383.29 ms	403.25 ms	19.96 ms
`91ac06a`	386.02 ms	407.53 ms	21.51 ms

App size

Revision	Plain	With Sentry	Diff
`6ef06c6`	1.58 MiB	2.09 MiB	520.53 KiB
`91ac06a`	1.58 MiB	2.09 MiB	520.52 KiB

markushi

Nice! I've left a nit about the transports, but looks good otherwise!

...core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java

cursor · Jul 30, 2025

...core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java

+    capabilities[0] = NetworkCapabilities.NET_CAPABILITY_INTERNET;
+    if (buildInfoProvider.getSdkInfoVersion() >= Build.VERSION_CODES.M) {
+      capabilities[1] = NetworkCapabilities.NET_CAPABILITY_VALIDATED;
+    }


Bug: Static Array Mutation Causes Network Capability Inconsistency

The static final capabilities array is mutated in the AndroidConnectionStatusProvider constructor based on instance-specific SDK versions. This creates a race condition where multiple instances, particularly those with different API levels, overwrite the shared static array, leading to inconsistent and incorrect network capability checks across all instances.

Locations (1)

sentry-android-core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java#L54-L78

While there might be multiple SDK instances running at a time, it's not possible for them to run on different API levels at the same time, because the device can only target one API level at a time.

…PC calls (#4560)

* Do not report cached events as lost * E2E tests for OpenTelemetry based console sample (#4563) * e2e tests for console app * fix test failures by waiting for 10s after first try to find envelopes * add system-test-runner.py script to replace bash scripts for running e2e / system tests * use py script for ci, cleanup, makefile * Format code * remove bash scripts * install requests module * api * fix gh script * Implement E2E tests for OTel based console sample * fixes after merge * Format code * e2e tests for console app * Implement E2E tests for OTel based console sample * fixes after merge * Format code * api * Reduce scope forking when using OpenTelemetry (#4565) * Reduce scope forking in OpenTelemetry * Format code * api * changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> * SDKs send queue is no longer shutdown immediately on re-init (#4564) * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * adapt tests * changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> * release: 8.18.0 * ref(replay): Use main thread to schedule capture (#4542) * perf(connectivity): Cache network capabilities and status to reduce IPC calls (#4560) * fix(breadcrumbs): Deduplicate battery breadcrumbs (#4561) * fix(ci): remove obsolete NDK debug symbols (#4581) As they don't exist anymore and this is done within sentry-native directly: https://github.com/getsentry/sentry-native/pull/1327/files * fix(android): Remove unused method (#4585) * fix(android): Remove unused method * Update Changelog * Add rules file for documenting SDK offline behaviour (#4572) #skip-changelog ## 📜 Description  Add rules file for documenting SDK offline behaviour ## 💡 Motivation and Context   Should help speed up AI reasoning about the SDK offline/retry behaviour. ## 💚 How did you test it? ## 📝 Checklist  - [ ] I added tests to verify the changes. - [ ] No new PII added or SDK only sends newly added PII if `sendDefaultPII` is enabled. - [ ] I updated the docs if needed. - [ ] I updated the wizard if needed. - [ ] Review from the native team if needed. - [ ] No breaking change or entry added to the changelog. - [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs. ## 🔮 Next steps * perf(connectivity): Have only one NetworkCallback active at a time (#4562) * fix(scripts): update-gradle script set-version (#4591) * fix: sentry-android-ndk proguard rule keeps all native class (#4427) * fix: sentry-androi-ndk proguard rule keeps all native class * docs: update CHANGELOG * fix: update CHANGELOG * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Markus Hintersteiner <m.hintersteiner@gmail.com> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> * refactor(lifecycle): Use single lifecycle observer (#4567) * perf(connectivity): Cache network capabilities and status to reduce IPC calls * changelog * Changelog * revert * fix(breadcrumbs): Deduplicate battery breadcrumbs * ref * Changelog * Fix test * perf(connectivity): Have only one NetworkCallback active at a time * Changelog * perf(integrations): Use single lifecycle observer * Add tests * Changelog * Fix tests * Improve callback handling and test visibility (#4593) * Null-check lifecycleObserver --------- Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> * fix(sqlite): Fix abstract method error (#4597) * fix(sqlite): Fix abstract method error * Update CHANGELOG.md * Suppress metadata version checks * perf(integrations): Do not register for SystemEvents and NetworkCallbacks when launched with background importance (#4579) * fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread (#4582) * fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread * Fix race conditions * Update Changelog * Update CHANGELOG.md * Address PR feedback * perf(executor): Prewarm SentryExecutorService (#4606) * review feedback * changelog * pass through whether cache stored in AndroidEnvelopeCache + test * Format code --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com> Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> Co-authored-by: Ghasem Shirdel <shirdelghasem79@gmail.com> Co-authored-by: Markus Hintersteiner <m.hintersteiner@gmail.com>

perf(connectivity): Cache network capabilities and status to reduce I…

2a0d6da

…PC calls

romtsn requested review from adinauer, lcian, markushi and stefanosiano as code owners July 16, 2025 15:34

romtsn added 4 commits July 16, 2025 17:35

Merge branch 'main' into rz/perf/less-ipc

0ac3081

changelog

14bb2d5

Changelog

c82586d

revert

7418781

romtsn commented Jul 16, 2025

View reviewed changes

Fix test

0153ab5

markushi approved these changes Jul 22, 2025

View reviewed changes

...core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java Outdated Show resolved Hide resolved

...core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java Show resolved Hide resolved

romtsn added 3 commits July 30, 2025 23:25

Merge branch 'main' into rz/perf/less-ipc

ba4416a

Address PR review

378bbfb

Merge branch 'main' into rz/perf/less-ipc

76a932b

romtsn enabled auto-merge (squash) July 30, 2025 21:40

cursor bot reviewed Jul 30, 2025

View reviewed changes

romtsn merged commit 3eb6466 into main Jul 30, 2025
34 checks passed

romtsn deleted the rz/perf/less-ipc branch July 30, 2025 21:52

adinauer pushed a commit that referenced this pull request Aug 8, 2025

perf(connectivity): Cache network capabilities and status to reduce I…

59250c4

…PC calls (#4560)

antonis mentioned this pull request Aug 11, 2025

chore(deps): v7: update Android SDK to v8.19.0 getsentry/sentry-react-native#5063

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf(connectivity): Cache network capabilities and status to reduce IPC calls #4560

perf(connectivity): Cache network capabilities and status to reduce IPC calls #4560

Uh oh!

romtsn commented Jul 16, 2025 •

edited

Loading

Uh oh!

romtsn Jul 16, 2025

Uh oh!

github-actions bot commented Jul 16, 2025 •

edited

Loading

Previous results on branch: rz/perf/less-ipc

Startup times

App size

Uh oh!

markushi left a comment

Uh oh!

Uh oh!

Uh oh!

cursor bot Jul 30, 2025

Uh oh!

romtsn Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

perf(connectivity): Cache network capabilities and status to reduce IPC calls #4560

perf(connectivity): Cache network capabilities and status to reduce IPC calls #4560

Uh oh!

Conversation

romtsn commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

Before (83 binder calls from SentryExecService)

After (5 binder calls from SentryExecService)

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

romtsn Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Previous results on branch: rz/perf/less-ipc

Startup times

App size

Uh oh!

markushi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot Jul 30, 2025

Choose a reason for hiding this comment

Bug: Static Array Mutation Causes Network Capability Inconsistency

Uh oh!

romtsn Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

romtsn commented Jul 16, 2025 •

edited

Loading

github-actions bot commented Jul 16, 2025 •

edited

Loading