docs: fix XML comments for boolean return of ILogEntryFilter - #5311
#5311Merged
jamescrosswell merged 1 commit intoJun 24, 2026
maingetsentry/sentry-dotnet:mainfrom
docs/extensions-logging-filters-fixgetsentry/sentry-dotnet:docs/extensions-logging-filters-fixCopy head branch name to clipboard
Merged
docs: fix XML comments for boolean return of ILogEntryFilter#5311jamescrosswell merged 1 commit intomaingetsentry/sentry-dotnet:mainfrom docs/extensions-logging-filters-fixgetsentry/sentry-dotnet:docs/extensions-logging-filters-fixCopy head branch name to clipboard
jamescrosswell merged 1 commit into
maingetsentry/sentry-dotnet:mainfrom
docs/extensions-logging-filters-fixgetsentry/sentry-dotnet:docs/extensions-logging-filters-fixCopy head branch name to clipboard
Conversation
Flash0ver
commented
Jun 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5311 +/- ##
==========================================
- Coverage 74.17% 74.16% -0.02%
==========================================
Files 508 508
Lines 18353 18353
Branches 3586 3586
==========================================
- Hits 13614 13612 -2
- Misses 3867 3869 +2
Partials 872 872 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Flash0ver
marked this pull request as ready for review
June 24, 2026 13:41
jamescrosswell
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix XML comments for
boolreturn ofILogEntryFilter.Remarks
Follow-up to #5297, where we did fix the grammar of one comment during review, but missed the 2nd comment.
See suggestion applied via #5297 (comment).
#skip-changelog, due to follow-up to still
Unreleasedchanges of #5297