Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: Unsampled spans no longer propagate empty trace headers - #4302

#4302
Merged
jamescrosswell merged 3 commits into
maingetsentry/sentry-dotnet:mainfrom
empty-trace-idgetsentry/sentry-dotnet:empty-trace-idCopy head branch name to clipboard
Jun 25, 2025
Merged

fix: Unsampled spans no longer propagate empty trace headers#4302
jamescrosswell merged 3 commits into
maingetsentry/sentry-dotnet:mainfrom
empty-trace-idgetsentry/sentry-dotnet:empty-trace-idCopy head branch name to clipboard

Conversation

@jamescrosswell

@jamescrosswell jamescrosswell commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Resolves #4301:

This PR corrects two issues from separate comments:

  • One in the HttpContextExtensions (see comment)
  • One in the UnsampledSpan class (see comment)

@jamescrosswell jamescrosswell mentioned this pull request Jun 24, 2025
Closed
@jamescrosswell
jamescrosswell marked this pull request as ready for review June 25, 2025 01:23
@jamescrosswell
jamescrosswell merged commit 7707813 into main Jun 25, 2025
31 checks passed
@jamescrosswell
jamescrosswell deleted the empty-trace-id branch June 25, 2025 01:24
This was referenced Jul 28, 2025
Closed
Closed
Merged
Closed
Open
This was referenced Aug 15, 2025
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Aug 27, 2025
Merged
This was referenced Sep 8, 2025
Closed
Closed
Closed
Closed
This was referenced Sep 15, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 2, 2025
Closed
Closed
Closed
This was referenced May 12, 2026
Closed
Closed
Merged
This was referenced May 25, 2026
Merged
Closed
Closed
This was referenced Jun 2, 2026
Closed
Open
Closed
Merged
@Flash0ver Flash0ver mentioned this pull request Jun 16, 2026
Draft
This was referenced Jun 19, 2026
Closed
Merged
This was referenced Jun 29, 2026
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Merged
This was referenced Jul 10, 2026
Merged
Merged
This was referenced Jul 18, 2026
Open
Open
Closed
Open
Closed
This was referenced Jul 27, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes
@Flash0ver Flash0ver Awaiting requested review from Flash0ver

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update from 5.10 to 5.11.1 "cannot be empty (Parameter 'traceId')"

2 participants

@jamescrosswell @bruno-garcia
Morty Proxy This is a proxified and sanitized view of the page, visit original site.