feat: replace libcurl with .NET HttpClient for sentry-native - #4222
#4222Merged
jpnurmi merged 13 commits intoJun 5, 2025
maingetsentry/sentry-dotnet:mainfrom
feat/native-transportgetsentry/sentry-dotnet:feat/native-transportCopy head branch name to clipboard
Merged
feat: replace libcurl with .NET HttpClient for sentry-native#4222jpnurmi merged 13 commits intomaingetsentry/sentry-dotnet:mainfrom feat/native-transportgetsentry/sentry-dotnet:feat/native-transportCopy head branch name to clipboard
jpnurmi merged 13 commits into
maingetsentry/sentry-dotnet:mainfrom
feat/native-transportgetsentry/sentry-dotnet:feat/native-transportCopy head branch name to clipboard
Conversation
jpnurmi
force-pushed
the
feat/native-transport
branch
3 times, most recently
from
May 29, 2025 20:35
a5dfd32 to
5b8a794
Compare
jpnurmi
force-pushed
the
feat/native-transport
branch
from
June 1, 2025 19:59
711e47f to
8764d14
Compare
Contributor
|
jpnurmi
force-pushed
the
feat/native-transport
branch
from
June 3, 2025 07:36
f81841c to
25efbb2
Compare
jpnurmi
marked this pull request as ready for review
June 3, 2025 13:17
jpnurmi
requested review from
Flash0ver,
aritchie and
jamescrosswell
as code owners
June 3, 2025 13:17
Flash0ver
reviewed
Jun 3, 2025
Flash0ver
reviewed
Jun 3, 2025
Flash0ver
reviewed
Jun 3, 2025
Flash0ver
reviewed
Jun 3, 2025
Flash0ver
reviewed
Jun 3, 2025
Flash0ver
reviewed
Jun 3, 2025
Flash0ver
reviewed
Jun 3, 2025
Flash0ver
reviewed
Jun 3, 2025
| _logger = logger; | ||
| } | ||
|
|
||
| protected override Task SerializeToStreamAsync(Stream stream, TransportContext? context) |
Contributor
There was a problem hiding this comment.
question: overload
I believe there is also a virtual overload of SerializeToStreamAsync that takes a CancellationToken cancellationToken.
Would we like to override this overload as well, so that we also support asynchronous cancellation?
(And then have this method call into the added method passing CancellationToken.None)
Collaborator
Author
There was a problem hiding this comment.
Supposedly, it needs some NET5_0_OR_GREATER guards to retain compatibility with older targets. Do you want to do that in this PR, or is that something that could be done in SerializableHttpContent as a separate step?
Contributor
There was a problem hiding this comment.
Oh ... right ... our SerializableHttpContent, that means this also applies to EnvelopeHttpContent.
Good call!
Yes. Let's improve that in a follow-up in a separate PR, because EnvelopeHttpContent currently does not support asynchronous cancellation either, for NET5_0_OR_GREATER.
Flash0ver
reviewed
Jun 3, 2025
Flash0ver
reviewed
Jun 3, 2025
This was referenced May 6, 2026
This was referenced May 25, 2026
This was referenced Jun 2, 2026
This was referenced Jun 19, 2026
This was referenced Jun 29, 2026
This was referenced Jul 10, 2026
This was referenced Jul 18, 2026
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install a custom function transport for sentry-native, and send native envelopes with the .NET HttpClient instead of relying on the default libcurl-based HTTP transport in sentry-native. This way, sentry-native can be built with
-DSENTRY_TRANSPORT=noneto eliminate the libcurl dependency, which is problematic for minimal/chiseled .NET Native AOT containers.The behavior remains virtually identical compared to the current native transport with libcurl. The Native AOT integration test that captures a native envelope on restart passes without any changes. The only difference is that native envelopes are sent with .NET HttpClient instead of libcurl. There's no native -> .NET envelope conversion nor hooks being called.
Close: #4116