Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove Library Signing from Sentry.Hangfire - #4099

#4099
Merged
jamescrosswell merged 18 commits into
maingetsentry/sentry-dotnet:mainfrom
4082-hangfire_remove_strong_naminggetsentry/sentry-dotnet:4082-hangfire_remove_strong_namingCopy head branch name to clipboard
May 8, 2025
Merged

Remove Library Signing from Sentry.Hangfire#4099
jamescrosswell merged 18 commits into
maingetsentry/sentry-dotnet:mainfrom
4082-hangfire_remove_strong_naminggetsentry/sentry-dotnet:4082-hangfire_remove_strong_namingCopy head branch name to clipboard

Conversation

@aritchie

Copy link
Copy Markdown
Contributor

Resolves #4082

@jamescrosswell
jamescrosswell marked this pull request as draft April 13, 2025 22:03
@aritchie
aritchie marked this pull request as ready for review April 15, 2025 17:48
@aritchie

Copy link
Copy Markdown
Contributor Author

@jamescrosswell Not sure why this was converted to a draft? The CI failure has nothing to do with this PR. I brought in the latest main just in case I'm missing something

@jamescrosswell
jamescrosswell marked this pull request as draft April 15, 2025 23:05
@aritchie
aritchie marked this pull request as ready for review April 16, 2025 23:01
@jamescrosswell

Copy link
Copy Markdown
Collaborator

@jamescrosswell Not sure why this was converted to a draft? The CI failure has nothing to do with this PR.

I can give feedback on PRs before the CI tests are all green, but can't approve anything until they all pass. If you've got questions about how to resolve any failing CI tests, let me know.

There aren't any outstanding issues with CI that I know of which would block PRs:

  • I think all of the chronic issues we've been having have been resolved in the last week. Those can be resolved by updating the branch from main then.
  • Sometimes you might have to rerun a particular job, if it's flaky

Generally, the author of the PR must work through any issues in CI (or ask for help if they're stuck) before marking the PR as ready for review.

@aritchie

Copy link
Copy Markdown
Contributor Author

@jamescrosswell All good now. I wasn't aware of the android or CI issues when I filed that. In any case, since merging latest main - all lights are about to go green on this PR

@jamescrosswell
jamescrosswell marked this pull request as draft April 17, 2025 03:47
Comment thread src/Sentry/SentryClientExtensions.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not load Hangfire.Core when using Sentry.Hangfire. A strongly-named assembly is required.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.