feat: public option to disable memeory introspection - #8571
#8571feat: public option to disable memeory introspection#8571NinjaLikesCheez wants to merge 4 commits intomaingetsentry/sentry-cocoa:mainfrom feat/disable-memory-introspectiongetsentry/sentry-cocoa:feat/disable-memory-introspectionCopy head branch name to clipboard
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- public option to disable memeory introspection ([#8571](https://github.com/getsentry/sentry-cocoa/pull/8571))If none of the above apply, you can opt out of this check by adding |
2d52405 to
c260f22
Compare
📲 Install BuildsiOS
|
Add documentation for the new enableMemoryIntrospection option that allows users to control whether memory introspection data is included in crash reports. This option helps users manage sensitive data by allowing them to disable stack contents capture near crash sites. - Add enableMemoryIntrospection option to configuration options - Update sensitive data documentation to mention memory introspection - Link between the two documentation sections for better discoverability Ref: getsentry/sentry-cocoa#8571
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ce33dcf | 1236.42 ms | 1267.76 ms | 31.34 ms |
| 0a8fa8a | 1230.72 ms | 1261.64 ms | 30.91 ms |
| 4455127 | 1216.29 ms | 1250.00 ms | 33.71 ms |
| 4e7765a | 1230.37 ms | 1265.84 ms | 35.47 ms |
| b557385 | 1211.45 ms | 1252.67 ms | 41.22 ms |
| 3efa7b5 | 1226.55 ms | 1260.66 ms | 34.11 ms |
| 0303c4f | 1229.73 ms | 1264.79 ms | 35.06 ms |
| 8469478 | 1240.30 ms | 1277.07 ms | 36.76 ms |
| bbc91e5 | 1215.94 ms | 1243.26 ms | 27.32 ms |
| 5bcf269 | 1223.60 ms | 1245.49 ms | 21.89 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ce33dcf | 24.14 KiB | 1.19 MiB | 1.16 MiB |
| 0a8fa8a | 24.14 KiB | 1.18 MiB | 1.15 MiB |
| 4455127 | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| 4e7765a | 24.14 KiB | 1.24 MiB | 1.22 MiB |
| b557385 | 24.14 KiB | 1.23 MiB | 1.20 MiB |
| 3efa7b5 | 24.14 KiB | 1.22 MiB | 1.19 MiB |
| 0303c4f | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| 8469478 | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| bbc91e5 | 24.14 KiB | 1.17 MiB | 1.14 MiB |
| 5bcf269 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c260f22. Configure here.
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM, after clarifying this important comment.
| * | ||
| * Disabling this will also disable the automatic 'memory corruption' diagnosis for crashes. | ||
| * | ||
| * @note Default value is @c YES. |
There was a problem hiding this comment.
h: Shouldn't we set the default to NO and point this out in the changelog? Strictly speaking you could argue that this is a breaking change, but I this is more of a bugfix so it's fine in a minor.
There was a problem hiding this comment.
We could argue all PII fixes are fine as breaking changes, so I agree with @philipphofmann
There was a problem hiding this comment.
Perfect, I'll make the changes today :)
📜 Description
Provide a public option to disable memory introspection on the crash reporter. This allows users to opt out of sending stack contents near the crash site, which may contain sensitive information.
💡 Motivation and Context
This change was requested by a user in #7501 to limit potential sensitive information disclosure.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #7501
sentry-docs PR: getsentry/sentry-docs#18838