Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

#11279: Fix - Error during WPS export via LayerDownload in specific scenarios - #11290

#11290
Merged
allyoucanmap merged 2 commits into
geosolutions-it:mastergeosolutions-it/MapStore2:masterfrom
dsuren1:#11279_wpsdsuren1/MapStore2:#11279_wpsCopy head branch name to clipboard
Jul 9, 2025
Merged

#11279: Fix - Error during WPS export via LayerDownload in specific scenarios#11290
allyoucanmap merged 2 commits into
geosolutions-it:mastergeosolutions-it/MapStore2:masterfrom
dsuren1:#11279_wpsdsuren1/MapStore2:#11279_wpsCopy head branch name to clipboard

Conversation

@dsuren1

@dsuren1 dsuren1 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes the error during WPS export when using Layer download in specific scenario

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?
WPS download operation works correctly in the following scenario

  • when empty filer
  • hide export button when WPS or WFS not supported for the layer
  • when service supports only wfs, then call is made with correct service type

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added this to the 2025.01.01 milestone Jul 7, 2025
@dsuren1
dsuren1 requested a review from allyoucanmap July 7, 2025 09:54
@dsuren1 dsuren1 self-assigned this Jul 7, 2025
@dsuren1 dsuren1 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch Regression labels Jul 7, 2025
@dsuren1 dsuren1 linked an issue Jul 7, 2025 that may be closed by this pull request
@allyoucanmap
allyoucanmap merged commit 21f3b55 into geosolutions-it:master Jul 9, 2025
6 checks passed
@allyoucanmap

Copy link
Copy Markdown
Contributor

@ElenaGallo please test this fix on dev and let us know when we can backport, thanks

@ElenaGallo

ElenaGallo commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

@dsuren1 see my comment below, thanks:

1_ If both WPS and WFS aren't supported for the layer, the Export button still visible on TOC. Try with Tasmania layer on this map

2_ If WPS not supported then WFS is auto selected but the WPS request on cosnole still present. Try with urban_areas layer on this map

sdasdsd

@dsuren1

dsuren1 commented Jul 10, 2025

Copy link
Copy Markdown
Contributor Author

@ElenaGallo

1_ If both WPS and WFS aren't supported for the layer, the Export button still visible on TOC. Try with Tasmania layer on this map

I don't see export button when either of the service is supported. i.e Export button on the export panel should be hidden, not the one on TOC
image

2_ If WPS not supported then WFS is auto selected but the WPS request on cosnole still present. Try with urban_areas layer on this map

That call is like a prerequisite, it is made regardless of the service. The download calls should be is fired with wfs service and able to download, which works fine. During download if it makes wps request then it's incorrect.

So to summarize, the functionality works as intended. Thanks for the observation

@ElenaGallo

Copy link
Copy Markdown
Contributor

@dsuren1 Thanks for the explanation. You can backport to 2025.01.xx. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Jul 10, 2025
tdipisa pushed a commit that referenced this pull request Jul 10, 2025
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error during WPS export via LayerDownload in specific scenarios

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.