Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Legend filter is persisted while editing a style causing inconsistencies #10236

Copy link
Copy link

Description

@allyoucanmap
Issue body actions

Description

The legend filter is not removed while editing a style of a WMS layer with the visual style editor, this can cause incosistency in the following cases:

  • selection of a different style (internal editing)
  • editing of the selected style and changing the rule with the visual style editor (internal editing)
  • creation of a new style with the visual style editor (internal editing)
  • external editing of a style (eg. on GeoServer) (external editing)

For all the internal editing we should intercept the events and correctly update the layer (it could be helpfull to take a look to the styleeditor epic where all the style editor logic is implemented).

For external cases I think we need a message inside the Legend component itself to let the user know that something is not aligned and a button to reset the legend filters

Important: the legend filter is part of the layerFilter that could have similar inconsistency problems so it's important to evaluate this task taking into account the whole property

What kind of improvement you want to add? (check one with "x", remove the others)

  • Investigation

Other useful information

Reactions are currently unavailable

Metadata

Metadata

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

Morty Proxy This is a proxified and sanitized view of the page, visit original site.