Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

dockutil #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 7, 2021
Merged

dockutil #106

merged 8 commits into from
May 7, 2021

Conversation

dspolleke
Copy link
Contributor

Because upstream contributor does not respond I added the functionality and made it work.

  • fixed default (empty) variable
  • fixed some strong language
  • fixed the tags (added block)
  • used command in stead of shell where possible.
  • loop vs with_items
  • added the default icons that Apple installs on that mile wide dock on Big Sur

@dspolleke
fix tags issue 97
70f0de3
@dspolleke
trailing spaces
be8b356
@dspolleke
dock util from https://github.com/enlewof \n Fixed default value for …
4dc3e75 
…variable, \ncreated block (for tags to work), \nFixed some strong language, \N fixed some shell / command preference (ansible-lint)
@dspolleke
working dockutil
299c9b7
@dspolleke
yamllinter
82979a7
@geerlingguy
Copy link
Owner

Original PR for reference: #84

geerlingguy
geerlingguy requested changes Apr 12, 2021
View reviewed changes
main.yml Outdated Show resolved Hide resolved
default.config.yml Outdated Show resolved Hide resolved
default.config.yml Outdated Show resolved Hide resolved
tasks/extra-packages.yml Outdated Show resolved Hide resolved
@dspolleke dspolleke requested a review from geerlingguy April 12, 2021 17:37
StephenBrown2 added a commit to StephenBrown2/mac-dev-playbook that referenced this pull request Apr 22, 2021
@StephenBrown2
Add personal changes
35c5406 
Include dockutil: geerlingguy#106
Include bootstrap from geerlingguy#96 (comment)
Use osx_defaults module: geerlingguy#79
@geerlingguy geerlingguy merged commit 97956cd into geerlingguy:master May 7, 2021
geerlingguy added a commit that referenced this pull request May 7, 2021
@geerlingguy
PR #106 follow-up: More consistent docs and examples.
f9f2d54
@geerlingguy
Copy link
Owner

Merged, but made sure nothing is changed by default, and also changed a few vars and styling for consistency.

kalopilato pushed a commit to kalopilato/mac-dev-playbook that referenced this pull request May 10, 2021
@geerlingguy @kalopilato
PR geerlingguy#106 follow-up: More consistent docs and examples.
ecbd9ba
dspolleke pushed a commit to dspolleke/mac-dev-playbook that referenced this pull request May 26, 2021
@geerlingguy @dspolleke
PR geerlingguy#106 follow-up: More consistent docs and examples.
bd6b7a0
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Mar 7, 2022
@geerlingguy
Merge pull request geerlingguy#106 from dspolleke/mydock
0065e5a 
dockutil
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Mar 7, 2022
@geerlingguy
PR geerlingguy#106 follow-up: More consistent docs and examples.
4c11406
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Mar 7, 2022
@geerlingguy @dspolleke
PR geerlingguy#106 follow-up: More consistent docs and examples.
f4606eb
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Jan 23, 2024
@geerlingguy @fabiogomezdiaz
PR geerlingguy#106 follow-up: More consistent docs and examples.
2b78144
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Jan 23, 2024
@geerlingguy @fabiogomezdiaz
PR geerlingguy#106 follow-up: More consistent docs and examples.
3123b6b
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Sep 5, 2025
@geerlingguy
Merge pull request geerlingguy#106 from dspolleke/mydock
c9b262b 
dockutil
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Sep 5, 2025
@geerlingguy
PR geerlingguy#106 follow-up: More consistent docs and examples.
2ec17eb
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Sep 5, 2025
@geerlingguy @dspolleke
PR geerlingguy#106 follow-up: More consistent docs and examples.
f028e15
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Sep 5, 2025
@geerlingguy @fabiogomezdiaz
PR geerlingguy#106 follow-up: More consistent docs and examples.
08bc9ee
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Sep 5, 2025
@geerlingguy @fabiogomezdiaz
PR geerlingguy#106 follow-up: More consistent docs and examples.
503fa98
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Sep 5, 2025
@geerlingguy
Merge pull request geerlingguy#106 from dspolleke/mydock
8cd7371 
dockutil
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Sep 5, 2025
@geerlingguy
PR geerlingguy#106 follow-up: More consistent docs and examples.
1fecbeb
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Sep 5, 2025
@geerlingguy @dspolleke
PR geerlingguy#106 follow-up: More consistent docs and examples.
f284cee
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Sep 6, 2025
@geerlingguy @fabiogomezdiaz
PR geerlingguy#106 follow-up: More consistent docs and examples.
03981a9
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Sep 6, 2025
@geerlingguy @fabiogomezdiaz
PR geerlingguy#106 follow-up: More consistent docs and examples.
6228e2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geerlingguy geerlingguy Awaiting requested review from geerlingguy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dspolleke @geerlingguy
Morty Proxy This is a proxified and sanitized view of the page, visit original site.