feat(fuzz): persist worker corpus immediately#15816
feat(fuzz): persist worker corpus immediately#15816decofe wants to merge 2 commits intocentaur/stack-corpus-mutator-prs-1784125633foundry-rs/foundry:centaur/stack-corpus-mutator-prs-1784125633from centaur/immediate-corpus-persistence-1784381329foundry-rs/foundry:centaur/immediate-corpus-persistence-1784381329Copy head branch name to clipboard
Conversation
|
derek bench invariant |
|
cc @0xalpharush bench (invariant) event published. Results will be reported separately. View publisher run Config: subcommand: |
| if is_gzip == gzip { | ||
| continue; | ||
| } | ||
| let tx_seq = entry.read_tx_seq()?; |
There was a problem hiding this comment.
This makes one corrupt/truncated corpus entry abort campaign preparation or finalization. The normal loader warns and skips unreadable entries; this rewrite should preserve that tolerance (or preferably avoid rewriting the whole corpus at campaign boundaries).
| if persist_now { | ||
| self.persist_optimization_state(); | ||
| } | ||
| self.persist_optimization_state(); |
There was a problem hiding this comment.
All workers can write the same optimization_best.json concurrently via truncate-and-write. Overlapping writes or a crash can leave malformed JSON or a lower best. Please keep this coordinator-owned, or use an atomic locked max update.
Summary
Validation
cargo +nightly fmt --all -- --checkgit diff --checkcargo metadata --no-deps --format-version 1cargo check -p foundry-evm --libcould not start because fetchingfoundry-rs/optimismreturned HTTP 401Stacked on #15763. Closes OSS-574
Prompted by: @0xalpharush