fix(vscode): align @types/vscode with engines.vscode so vsce can package by forinda · Pull Request #424 · forinda/kick-js

forinda · Jun 16, 2026

Problem

pnpm --filter kickjs-devtools package (→ vsce package) failed:

ERROR  @types/vscode ^1.120.0 greater than engines.vscode ^1.85.0.
Either upgrade engines.vscode or use an older @types/vscode version

vsce enforces that the declared @types/vscode range minimum is ≤ engines.vscode. The devDependency had drifted to ^1.120.0 while the engine floor stayed at ^1.85.0.

Fix

Lower @types/vscode to ^1.85.0 (match the engine floor) rather than bumping engines.vscode:

The extension uses no API newer than 1.85 — SecretStorage, webviews, and the command APIs all predate it.
Bumping engines instead would drop support for users on VS Code 1.85–1.119 for no benefit.
Build is unaffected: tsc still resolves whatever 1.x typings pnpm installs.

Also sets the marketplace publisher to forinda82.

Verify

pnpm build && vsce package
→ DONE  Packaged: kickjs-devtools-5.3.0.vsix (20 files, 26.13 KB)

kickjs-devtools is a private package (no changeset — manual version, currently 5.3.0).

🤖 Generated with Claude Code

Summary by CodeRabbit

Chores
- Updated VS Code extension publisher identity
- Updated TypeScript type definitions for improved compatibility with VS Code engine requirements

`vsce package` failed: ERROR @types/vscode ^1.120.0 greater than engines.vscode ^1.85.0. Either upgrade engines.vscode or use an older @types/vscode version vsce requires the declared @types/vscode range minimum to be <= engines.vscode. Lower @types/vscode to ^1.85.0 to match the engine floor — the extension uses no API newer than 1.85 (SecretStorage, webviews, commands all predate it), so this keeps it installable on VS Code 1.85+ rather than narrowing the floor to 1.120. Build is unaffected (tsc still resolves the installed 1.x typings). Also sets the marketplace publisher to `forinda82`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

coderabbitai · Jun 16, 2026

📝 Walkthrough

Walkthrough

The VS Code extension manifest (package.json) receives two field changes: the publisher value is updated from forinda to forinda82, and the @types/vscode dev dependency version is downgraded from ^1.120.0 to ^1.85.0, aligning it with the existing vscode engine requirement.

Changes

VS Code Extension Manifest Updates

Layer / File(s)	Summary
Publisher and type definition version `packages/vscode-extension/package.json`	`publisher` changed from `forinda` to `forinda82`; `@types/vscode` devDependency downgraded from `^1.120.0` to `^1.85.0` to match the `vscode` engine floor.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A publisher rebranded, a version brought low,
Two little fields in the JSON aglow.
From forinda to forinda82 I hop,
The types now align — the version mismatch stops.
Small changes, big joy — off to the marketplace I go! 🎉

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: aligning `@types/vscode` with engines.vscode to resolve the vsce packaging error.
Description check	✅ Passed	The description provides clear problem statement, detailed fix rationale, and verification; however it deviates from the template structure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/vscode-types-engine

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/vscode-extension/package.json`:
- Line 362: The pnpm-lock.yaml file is out of sync with the updated
`@types/vscode` specifier in package.json. Run pnpm install to regenerate the lock
file so it reflects the current package.json dependencies. Note that this will
likely resolve `@types/vscode` to version 1.120.0 (the latest within the ^1.85.0
range); if the intent is to pin to a version closer to 1.85.0 that better
matches the engines.vscode requirement, consider updating the version specifier
in package.json to use a more restrictive range like ~1.85.0 or an explicit
version like 1.85.0 before running pnpm install.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e3ef9e38-3831-426c-8f9e-070cec7cf939

📥 Commits

Reviewing files that changed from the base of the PR and between 8e0b4be and 9e06ffb.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

packages/vscode-extension/package.json

coderabbitai · Jun 16, 2026

  },
  "devDependencies": {
-    "@types/vscode": "^1.120.0",
+    "@types/vscode": "^1.85.0",


⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash # Description: Check if pnpm-lock.yaml has the correct `@types/vscode` resolution after pnpm install # Search for the `@types/vscode` resolution in the lock file rg -A 2 "`@types/vscode`" pnpm-lock.yaml

Repository: forinda/kick-js

Length of output: 360

🏁 Script executed:

# Check current package.json to see the `@types/vscode` specifier cat -n packages/vscode-extension/package.json | sed -n '355,370p'

Repository: forinda/kick-js

Length of output: 573

🏁 Script executed:

# Check if there are any related issues or comments about vsce package error rg -i "vsce|package.*error" packages/vscode-extension/ --type json --type ts --type md -B 2 -A 2

Repository: forinda/kick-js

Length of output: 403

🏁 Script executed:

# Check what npm registry shows for `@types/vscode` versions near 1.85.0 web_search "`@types/vscode` npm package versions 1.85 1.120"

Repository: forinda/kick-js

Length of output: 110

🏁 Script executed:

# Check what `@types/vscode` versions are available and their relationship to vscode versions cd packages/vscode-extension && pnpm list `@types/vscode` 2>&1 || echo "pnpm list failed, checking lock file details"

Repository: forinda/kick-js

Length of output: 145

🏁 Script executed:

# Look for any comments or issues in the codebase about the vsce package error mentioned rg -i "vsce|1\.120|1\.85" packages/vscode-extension/ -B 3 -A 3

Repository: forinda/kick-js

Length of output: 1183

🌐 Web query:

@types/vscode version 1.85.0 1.120.0 npm release dates changelog

💡 Result:

The npm package @types/vscode provides TypeScript definitions for the Visual Studio Code API [1][2]. As of June 16, 2026, the release dates for the requested versions are: @types/vscode version 1.85.0: Published in December 2023. This release corresponds with the VS Code November 2023 release (v1.85) [3][4]. @types/vscode version 1.120.0: Published on May 13, 2026 [2][5][6]. The @types/vscode package does not maintain a traditional human-readable changelog file within the npm package itself [1][2]. Instead, the package serves as the TypeScript definition file (vscode.d.ts) for the VS Code API, and updates to these types are typically synchronized with the corresponding VS Code editor release [7]. Changes can be tracked via the DefinitelyTyped repository on GitHub, where updates are submitted as pull requests [6]. For specific API changes, developers should refer to the official Visual Studio Code release notes for the corresponding version [3][4].

Citations:

1: https://registry.npmjs.org/%40types%2Fvscode

2: https://registry.npmjs.org/@types/vscode

3: https://github.com/microsoft/vscode/releases/tag/1.85.0

4: https://code.visualstudio.com/updates/v1_85

5: https://www.npmjs.com/package/@types/vscode?activeTab=versions

6: chore: update @types/vscode for 1.120 DefinitelyTyped/DefinitelyTyped#74995

7: https://github.com/microsoft/vscode/wiki/Publish-vscode-types

Regenerate pnpm-lock.yaml with the updated package.json specifier.

The lock file still shows version: 1.120.0 for @types/vscode even though package.json now specifies ^1.85.0. Run pnpm install to regenerate the lock file and ensure consistency.

However, note that pnpm install will likely resolve @types/vscode to 1.120.0 (the latest version within the ^1.85.0 range), not an earlier version. If the intent was to pin to a specific earlier version that better matches the engines.vscode: ^1.85.0 requirement, update the specifier to target that version explicitly (e.g., ~1.85.0 or a specific version like 1.85.0).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/vscode-extension/package.json` at line 362, The pnpm-lock.yaml file is out of sync with the updated `@types/vscode` specifier in package.json. Run pnpm install to regenerate the lock file so it reflects the current package.json dependencies. Note that this will likely resolve `@types/vscode` to version 1.120.0 (the latest within the ^1.85.0 range); if the intent is to pin to a version closer to 1.85.0 that better matches the engines.vscode requirement, consider updating the version specifier in package.json to use a more restrictive range like ~1.85.0 or an explicit version like 1.85.0 before running pnpm install.

coderabbitai Bot reviewed Jun 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(vscode): align @types/vscode with engines.vscode so vsce can package#424

fix(vscode): align @types/vscode with engines.vscode so vsce can package#424
forinda wants to merge 1 commit into
mainforinda/kick-js:mainfrom
fix/vscode-types-engineforinda/kick-js:fix/vscode-types-engineCopy head branch name to clipboard

forinda commented Jun 16, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 16, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Search code, repositories, users, issues, pull requests...

Conversation

forinda commented Jun 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Verify

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

forinda commented Jun 16, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 16, 2026 •

edited

Loading