Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

include all generated part files in animated_icons_private_test#14329

Merged
amirh merged 1 commit into
flutter:masterflutter/flutter:masterfrom
amirh:analysis-erroramirh/flutter:analysis-errorCopy head branch name to clipboard
Jan 29, 2018
Merged

include all generated part files in animated_icons_private_test#14329
amirh merged 1 commit into
flutter:masterflutter/flutter:masterfrom
amirh:analysis-erroramirh/flutter:analysis-errorCopy head branch name to clipboard

Conversation

@amirh

@amirh amirh commented Jan 29, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@Hixie

Hixie commented Jan 29, 2018

Copy link
Copy Markdown
Contributor

How come this wasn't caught by Travis or the infrabots, only by devicelab?

cc @yjbanov

@Hixie

Hixie commented Jan 29, 2018

Copy link
Copy Markdown
Contributor

LGTM

@Hixie

Hixie commented Jan 29, 2018

Copy link
Copy Markdown
Contributor

dart-lang/sdk#31998

@amirh
amirh merged commit 2e449f0 into flutter:master Jan 29, 2018
@amirh
amirh deleted the analysis-error branch January 29, 2018 22:26
@cbracken

Copy link
Copy Markdown
Member

This appears to have bumped the flutter analyzer watch benchmark into the orange.

@amirh

amirh commented Jan 30, 2018

Copy link
Copy Markdown
Contributor Author

I'm following up with the VM team to see if this is expected.

DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.