Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Reworked formatting and support multi-dimensional arrays. #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Reworked formatting and support multi-dimensional arrays. #3009

merged 1 commit into from
Mar 13, 2025

Conversation

dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Feb 10, 2025 •
edited
Loading

While trying to fix #2696, I decided to redesign the implementation of the FormattedObjectGraph to make it easier to understand.

Fixes #2696

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dennisdoomen dennisdoomen force-pushed the fix/2695-use-line-breaks branch 4 times, most recently from e177086 to d2088c8 Compare February 10, 2025 14:45
jnyrup
jnyrup reviewed Feb 10, 2025
View reviewed changes
Tests/FluentAssertions.Specs/Formatting/FormatterSpecs.cs Outdated Show resolved Hide resolved
Tests/FluentAssertions.Specs/Formatting/FormattedObjectGraphSpecs.cs Outdated Show resolved Hide resolved
Tests/FluentAssertions.Specs/Formatting/FormattedObjectGraphSpecs.cs Outdated Show resolved Hide resolved
@dennisdoomen dennisdoomen force-pushed the fix/2695-use-line-breaks branch 2 times, most recently from 10bdb36 to 7ad7fea Compare February 10, 2025 21:08
@IT-VBFK IT-VBFK mentioned this pull request Feb 10, 2025
Closed
@dennisdoomen dennisdoomen force-pushed the fix/2695-use-line-breaks branch 6 times, most recently from 7017f86 to 609980e Compare February 15, 2025 12:53
@dennisdoomen dennisdoomen changed the base branch from support-7.0 to main February 15, 2025 12:53
@dennisdoomen dennisdoomen added this to the 8.1.0 milestone Feb 15, 2025
@dennisdoomen dennisdoomen force-pushed the fix/2695-use-line-breaks branch 13 times, most recently from 7efd24e to 6de822e Compare February 16, 2025 21:18
This was referenced Oct 8, 2025
Open
Closed
Closed
Open
Open
Open
Closed
Closed
Open
Closed
Closed
Closed
Open
Closed
Closed
Closed
Open
Closed
Closed
This was referenced Oct 15, 2025
Closed
Closed
Merged
Open
Open
Closed
Open
Open
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

8.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dennisdoomen @coveralls @jnyrup
Morty Proxy This is a proxified and sanitized view of the page, visit original site.