Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Capitalize true and false in failure messages - #2390

#2390
Merged
dennisdoomen merged 2 commits into
fluentassertions:developfluentassertions/fluentassertions:developfrom
BusHero:patch-1BusHero/fluentassertions:patch-1Copy head branch name to clipboard
Oct 17, 2023
Merged

Capitalize true and false in failure messages#2390
dennisdoomen merged 2 commits into
fluentassertions:developfluentassertions/fluentassertions:developfrom
BusHero:patch-1BusHero/fluentassertions:patch-1Copy head branch name to clipboard

Conversation

@BusHero

@BusHero BusHero commented Oct 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Display true and false as capitalized rather than in lowercase so that both expected value and actual value uses the same casing.

Before: Expected boolean to be false, but found True.
After: Expected boolean to be False, but found True.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@BusHero
chore: capitalize true and false
c6af9d6 
Display 'true' and 'false' as capitalized rathen than in lowercase so that both expected value and actual value uses the same casing.
---Before---
"Expected boolean to be false, but found True."
---After---
"Expected boolean to be False, but found True."
@github-actions

github-actions Bot commented Oct 16, 2023 •
edited
Loading

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@jnyrup

jnyrup commented Oct 16, 2023

Copy link
Copy Markdown
Member

Bonus: BeTrue/BeFalse now match the output of NullableBooleanAssertions's NotBeFalse/NotBeTrue.

@dennisdoomen dennisdoomen changed the title chore: capitalize true and false Capitalize true and false in failure messages Oct 17, 2023
@dennisdoomen

dennisdoomen commented Oct 17, 2023

Copy link
Copy Markdown
Member

Do you think it's worth some release notes in releases.md?

@BusHero

BusHero commented Oct 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Do you think it's worth some release notes in releases.md?

sure

@dennisdoomen
dennisdoomen merged commit 514ed4c into fluentassertions:develop Oct 17, 2023
@BusHero
BusHero deleted the patch-1 branch October 18, 2023 07:55
@jnyrup jnyrup added enhancement and removed bug labels Feb 11, 2024
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@BusHero @jnyrup
Capitalize true and false in failure messages (fluentassertions#2390)
333e6a4 
* chore: capitalize true and false

Display 'true' and 'false' as capitalized rathen than in lowercase so that both expected value and actual value uses the same casing.
---Before---
"Expected boolean to be false, but found True."
---After---
"Expected boolean to be False, but found True."

* docs: update releases.md
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@BusHero @jnyrup
Capitalize true and false in failure messages (fluentassertions#2390)
c56f67d 
* chore: capitalize true and false

Display 'true' and 'false' as capitalized rathen than in lowercase so that both expected value and actual value uses the same casing.
---Before---
"Expected boolean to be false, but found True."
---After---
"Expected boolean to be False, but found True."

* docs: update releases.md
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@BusHero @jnyrup
Capitalize true and false in failure messages (fluentassertions#2390)
5085179 
* chore: capitalize true and false

Display 'true' and 'false' as capitalized rathen than in lowercase so that both expected value and actual value uses the same casing.
---Before---
"Expected boolean to be false, but found True."
---After---
"Expected boolean to be False, but found True."

* docs: update releases.md
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@BusHero @jnyrup
Capitalize true and false in failure messages (fluentassertions#2390)
4f0bec5 
* chore: capitalize true and false

Display 'true' and 'false' as capitalized rathen than in lowercase so that both expected value and actual value uses the same casing.
---Before---
"Expected boolean to be false, but found True."
---After---
"Expected boolean to be False, but found True."

* docs: update releases.md
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@BusHero @jnyrup
Capitalize true and false in failure messages (fluentassertions#2390)
cab78eb 
* chore: capitalize true and false

Display 'true' and 'false' as capitalized rathen than in lowercase so that both expected value and actual value uses the same casing.
---Before---
"Expected boolean to be false, but found True."
---After---
"Expected boolean to be False, but found True."

* docs: update releases.md
jnyrup pushed a commit that referenced this pull request Sep 9, 2024
@BusHero @jnyrup
Capitalize true and false in failure messages (#2390)
e111c83 
* chore: capitalize true and false

Display 'true' and 'false' as capitalized rathen than in lowercase so that both expected value and actual value uses the same casing.
---Before---
"Expected boolean to be false, but found True."
---After---
"Expected boolean to be False, but found True."

* docs: update releases.md
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 17, 2026
Open
Closed
Closed
Closed
Open
Closed
Open
Open
Open
Closed
Closed
Closed
Closed
Merged
Open
Open
Open
Closed
Closed
Open
This was referenced Jul 26, 2026
Open
Open
Closed
Merged
Open
Open
Closed
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BusHero @jnyrup @dennisdoomen
Morty Proxy This is a proxified and sanitized view of the page, visit original site.