Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add extensions for OccurrenceConstraint that reads more fluently - #2047

#2047
Merged
dennisdoomen merged 10 commits into
fluentassertions:developfluentassertions/fluentassertions:developfrom
IT-VBFK:issue-2045IT-VBFK/fluentassertions:issue-2045Copy head branch name to clipboard
Jan 1, 2023
Merged

Add extensions for OccurrenceConstraint that reads more fluently#2047
dennisdoomen merged 10 commits into
fluentassertions:developfluentassertions/fluentassertions:developfrom
IT-VBFK:issue-2045IT-VBFK/fluentassertions:issue-2045Copy head branch name to clipboard

Conversation

@IT-VBFK

@IT-VBFK IT-VBFK commented Nov 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Authored by @siewers, committed by @IT-VBFK

Closes #2045

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

@dennisdoomen

dennisdoomen commented Nov 28, 2022

Copy link
Copy Markdown
Member

Is this still work in progress?

@IT-VBFK
IT-VBFK force-pushed the issue-2045 branch 2 times, most recently from 784056a to 0c77b25 Compare November 28, 2022 19:38
@IT-VBFK

IT-VBFK commented Nov 28, 2022

Copy link
Copy Markdown
Contributor Author

Not really, why?

@dennisdoomen

dennisdoomen commented Nov 28, 2022

Copy link
Copy Markdown
Member

Just checking whether I can start reviewing it.

@IT-VBFK

IT-VBFK commented Nov 28, 2022

Copy link
Copy Markdown
Contributor Author

Oh.. yes :)
sorry

@coveralls

coveralls commented Nov 28, 2022 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3794573532

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 96.94%
Totals Coverage Status
Change from base Build 3789210470: 0.9%
Covered Lines: 12476
Relevant Lines: 12719
💛 - Coveralls

@jnyrup

jnyrup commented Nov 28, 2022

Copy link
Copy Markdown
Member

Please, can we agree on the API in #2045 first. 🙏

I see I really need to get this written, but the label "api-suggestion" is supposed to mean "this is a suggestion for a modification to the public api, but it is not yeat ready for implementation".
"api-approved" is "this is ready for implementation".

@IT-VBFK

IT-VBFK commented Nov 28, 2022

Copy link
Copy Markdown
Contributor Author

Please, can we agree on the API in #2045 first. 🙏

Then.. I will make this a WIP..

@IT-VBFK
IT-VBFK marked this pull request as draft November 28, 2022 19:46
@IT-VBFK
IT-VBFK force-pushed the issue-2045 branch 2 times, most recently from 7a51917 to 95e4eff Compare December 28, 2022 14:22
@IT-VBFK
IT-VBFK marked this pull request as ready for review December 28, 2022 15:30
@jnyrup jnyrup added the feature label Dec 29, 2022
jnyrup
jnyrup reviewed Dec 30, 2022
View reviewed changes
Comment thread docs/_pages/releases.md
@IT-VBFK
IT-VBFK requested a review from jnyrup December 30, 2022 10:34
jnyrup
jnyrup reviewed Dec 30, 2022
View reviewed changes
Comment thread Tests/FluentAssertions.Specs/OccurrenceConstraintSpecs.cs Outdated
@jnyrup
jnyrup requested a review from dennisdoomen December 30, 2022 11:09
@IT-VBFK

IT-VBFK commented Dec 30, 2022

Copy link
Copy Markdown
Contributor Author

Just a note: Please make sure to add the line "Authored by @siewers, committed by @IT-VBFK" in the commit message, to give @siewers the credit for the change, because it is actually his work :)

@IT-VBFK IT-VBFK changed the title Add extensions for occurrence constraint that reads more fluently Add extensions for OccurrenceConstraint that reads more fluently Dec 30, 2022
dennisdoomen
dennisdoomen requested changes Jan 1, 2023
View reviewed changes

@dennisdoomen dennisdoomen left a comment •
edited by jnyrup
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update strings.md to show the new way.

Comment thread Src/FluentAssertions/Extensions/OccurrenceConstraintExtensions.cs
Comment thread docs/_pages/releases.md Outdated
This was referenced Mar 24, 2026
Closed
Merged
This was referenced Apr 3, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Apr 15, 2026
Closed
This was referenced Apr 22, 2026
Closed
Open
Closed
This was referenced Apr 30, 2026
Closed
Merged
Closed
Open
This was referenced May 8, 2026
Closed
Open
Open
Open
Open
Closed
This was referenced May 15, 2026
Open
Closed
Open
Open
Open
This was referenced May 27, 2026
Open
Open
Closed
This was referenced Jun 4, 2026
Open
Open
This was referenced Jun 29, 2026
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes
@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include extension methods for OccurrenceConstraint that reads more fluently

4 participants

@IT-VBFK @dennisdoomen @coveralls @jnyrup
Morty Proxy This is a proxified and sanitized view of the page, visit original site.