Extend collection assertions with `ContainInConsecutiveOrder` and `NotContainInConsecutiveOrder` by StacyCash · Pull Request #1963 · fluentassertions/fluentassertions

StacyCash · Jul 26, 2022

Adds ContainInConsecutiveOrder and NotContainInConsecutiveOrder to check that a collection is contained within another in order and with no gaps.

This will close #1956

IMPORTANT

The code complies with the Coding Guidelines for C#.
The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

Two functions to check that a cleections contains or doesn't contain the items from a second collections consecutively.

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

coveralls · Jul 27, 2022

Pull Request Test Coverage Report for Build 2754590099

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 96.654%

Totals
Change from base Build 2726577378:	1.0%
Covered Lines:	12302
Relevant Lines:	12568

💛 - Coveralls

jnyrup

The code coverage reports two branch misses.
If you login to coveralls.io with with your github account, you can inspect the report there.
Alternatively you can run ./build.ps1 locally and look inTestResults\reports\index.html.

Do you intend to apply the optimizations I suggested in #1956 (comment)?
I should not be necessary to do any calls ToArray().
If you prefer, I can also have a look at that. Just let me know.

dennisdoomen

Thanks for the contribution.

StacyCash · Jul 28, 2022

@jnyrup I've looked at your changes and rewritten both the ContainsInConsecutitveOrder and NotContainsInConsecutiveOrder based it. Thanks! They are both much easier to read now.

jnyrup · Jul 28, 2022

Major improvement!
Now I only have a few styling comments.

I haven't looked deeply into the tests, but it seems we could use a test when calling with an empty expected/unexpected.

StacyCash · Jul 28, 2022

There is an empty test for NotContainsInConsecuritveOrder, I've added the same for ContainsInConsecutiveOrder

If you let me know the style issues I'll either look at them in the morning or when I return.

jnyrup

If you let me know the style issues I'll either look at them in the morning or when I return.

The style comments were still pending 🤦‍♂️

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

StacyCash added 3 commits July 19, 2022 21:29

Add ContainInConsecutiveOrder and NotContainInConsecutiveOrder

f4a8c68

Two functions to check that a cleections contains or doesn't contain the items from a second collections consecutively.

Optimise searching for expected list

4fad081

Make NotContainsInConsecutiveOrder more efficient

46a4135

eNeRGy164 reviewed Jul 26, 2022

View reviewed changes

Comment thread Src/FluentAssertions/Collections/GenericCollectionAssertions.cs Outdated

jnyrup changed the title ~~Extend GenericCollectionAssertions for ContainsInConsecutiveOrder and NotContainsInConsecutiveOrder~~ Extend GenericCollectionAssertions for ContainInConsecutiveOrder and NotContainInConsecutiveOrder Jul 26, 2022

jnyrup reviewed Jul 26, 2022

View reviewed changes

Comment thread Tests/FluentAssertions.Specs/Collections/CollectionAssertionSpecs.ContainInConsecutiveOrder.cs Outdated

Comment thread docs/_pages/releases.md Outdated

eNeRGy164 reviewed Jul 26, 2022

View reviewed changes

Comment thread docs/_pages/releases.md Outdated

StacyCash and others added 4 commits July 26, 2022 15:26

Update docs/_pages/releases.md

356f7c7

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

Rename Explicit to Consecutive

fafd108

Format code based on PR comments

f3e97c1

Rename Explicit to Consecuritve for the test classes

9587001

StacyCash requested a review from jnyrup July 26, 2022 13:57

dennisdoomen changed the title ~~Extend GenericCollectionAssertions for ContainInConsecutiveOrder and NotContainInConsecutiveOrder~~ Extend collection assertions with ContainInConsecutiveOrder and NotContainInConsecutiveOrder Jul 27, 2022

jnyrup reviewed Jul 27, 2022

View reviewed changes

dennisdoomen requested changes Jul 27, 2022

View reviewed changes

Comment thread Src/FluentAssertions/Collections/GenericCollectionAssertions.cs

StacyCash added 4 commits July 28, 2022 14:56

Refactor/rewrite ContainInConsecutiveOrder

54790a0

Merge branch 'fluentassertions:develop' into develop

7eef1ba

Rewrote based on @jnyrup improvements

23e8059

Rewrite NotContainsInConsecuritveOrder

2a940fe

StacyCash requested review from dennisdoomen and jnyrup July 28, 2022 14:51

Add test for ContainsInConsecutiveOrder when expected is empty

a5be6cb

jnyrup reviewed Jul 30, 2022

View reviewed changes

Comment thread Src/FluentAssertions/Collections/GenericCollectionAssertions.cs Outdated

Comment thread Src/FluentAssertions/Collections/GenericCollectionAssertions.cs Outdated

Comment thread Src/FluentAssertions/Collections/GenericCollectionAssertions.cs Outdated

StacyCash and others added 3 commits August 1, 2022 11:54

Update Src/FluentAssertions/Collections/GenericCollectionAssertions.cs

9313fe7

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

Update Src/FluentAssertions/Collections/GenericCollectionAssertions.cs

b560ef6

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

Update Src/FluentAssertions/Collections/GenericCollectionAssertions.cs

e58610e

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

dependabot Bot mentioned this pull request Nov 3, 2025

Bump FluentAssertions from 5.10.3 to 8.8.0 openwallet-foundation-labs/wallet-framework-dotnet#445

Closed

This was referenced Nov 10, 2025

Bump FluentAssertions from 5.10.3 to 8.8.0 openwallet-foundation-labs/wallet-framework-dotnet#452

Closed

Bump FluentAssertions from 5.10.3 to 8.8.0 openwallet-foundation-labs/wallet-framework-dotnet#469

Closed

This was referenced Nov 24, 2025

Bump FluentAssertions from 5.10.3 to 8.8.0 openwallet-foundation-labs/wallet-framework-dotnet#476

Closed

Bump FluentAssertions from 5.10.3 to 8.8.0 jleachenski/AspNetCore-DDD#12

Open

This was referenced Dec 22, 2025

Bump FluentAssertions from 5.10.3 to 8.8.0 petrikero/akka.net#34

Open

Bump FluentAssertions from 5.10.3 to 8.8.0 ChrisKXu/todl#122

Closed

This was referenced Jan 11, 2026

Bump FluentAssertions from 5.10.3 to 8.8.0 thashiznit2003/Bookdarr#9

Merged

Bump FluentAssertions from 6.4.0 to 8.8.0 angeldev99/dotnet-reactive#2

Open

dependabot Bot mentioned this pull request Feb 8, 2026

Bump FluentAssertions from 6.6.0 to 8.8.0 WaterLemons2k/BililiveRecorder#19

Merged

dependabot Bot mentioned this pull request Mar 9, 2026

Bump FluentAssertions from 5.10.3 to 8.8.0 RocketSurgeonsGuild/ReactiveUI.Interop#335

Closed

dependabot Bot mentioned this pull request Mar 17, 2026

Bump FluentAssertions from 5.10.3 to 8.9.0 RocketSurgeonsGuild/ReactiveUI.Interop#360

Closed

This was referenced Mar 24, 2026

dependabot: Bump FluentAssertions from 6.7.0 to 8.9.0 rmandvikar/delegating-handlers#1

Closed

dependabot: Bump FluentAssertions from 6.7.0 to 7.2.2 rmandvikar/delegating-handlers#7

Merged

This was referenced Apr 3, 2026

Bump FluentAssertions from 6.6.0 to 8.9.0 Brightspace/D2L.Security.OAuth2#385

Closed

Bump FluentAssertions from 5.10.3 to 8.9.0 Swartdraak/Bibliophilarr#44

Closed

dependabot Bot mentioned this pull request Apr 15, 2026

Bump FluentAssertions from 6.2.0 to 8.9.0 devpro/mongodb-atlas-dotnet-client#176

Closed

This was referenced Apr 22, 2026

Bump FluentAssertions from 5.10.3 to 8.9.0 akkadotnet/Akka.Persistence.MongoDB#439

Closed

Bump FluentAssertions from 5.10.3 to 8.9.0 yscorecore/YS.Knife.Query#11

Open

Bump FluentAssertions from 5.10.3 to 8.9.0 Arkatufus/Akka.Persistence.MongoDB#53

Closed

dependabot Bot mentioned this pull request May 8, 2026

Bump FluentAssertions from 5.10.3 to 8.9.0 TechnologyEnhancedLearning/DLSV2#3561

Closed

dependabot Bot mentioned this pull request Jun 1, 2026

Bump FluentAssertions from 6.4.0 to 7.2.2 dotnet/reactive#2324

Open

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

StacyCash commented Jul 26, 2022 • edited by jnyrup Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

IMPORTANT

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 2754590099

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

jnyrup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dennisdoomen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StacyCash commented Jul 28, 2022

Uh oh!

jnyrup commented Jul 28, 2022

Uh oh!

StacyCash commented Jul 28, 2022

Uh oh!

jnyrup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

StacyCash commented Jul 26, 2022 •

edited by jnyrup

Loading

coveralls commented Jul 27, 2022 •

edited

Loading