Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(imap): oauth2 url fix for outlook#1701

Open
1unarzDev wants to merge 1 commit into
floatpane:masterfloatpane/matcha:masterfrom
1unarzDev:fix1unarzDev/matcha:fixCopy head branch name to clipboard
Open

fix(imap): oauth2 url fix for outlook#1701
1unarzDev wants to merge 1 commit into
floatpane:masterfloatpane/matcha:masterfrom
1unarzDev:fix1unarzDev/matcha:fixCopy head branch name to clipboard

Conversation

@1unarzDev

Copy link
Copy Markdown

What?

  • Added try-catch block to make it easier to debug OAuth2 errors encountered while authenticating IMAP.
  • Revised Outlook URL generation code for updated Entra ID redirect

Why?

I wasn't able to authenticate my Outlook emails previously. I'm not fully sure if the documentation clearly states that you need your Entra ID redirect to be configured as "Web" rather than "Mobile & Desktop App," but that is also a needed fix.

@1unarzDev
1unarzDev requested a review from a team as a code owner July 24, 2026 18:44
@floatpanebot floatpanebot added area/oauth OAuth / XOAUTH2 / auth flows bug Something isn't working area/config Configuration / settings documentation Documentation changes os/windows Windows-specific labels Jul 24, 2026

@floatpanebot floatpanebot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @1unarzDev! Please fix the following issues with your PR:

  • Title: Is too long (67 characters). The PR title must be strictly under 40 characters.

@floatpanebot floatpanebot added the size/S Diff: 11–50 lines label Jul 24, 2026
@1unarzDev 1unarzDev changed the title fix(imap): oauth2 url generation fix for microsoft outlook entra id fix(imap): oauth2 url fix for outlook Jul 24, 2026
@floatpanebot
floatpanebot dismissed their stale review July 24, 2026 18:45

Formatting issues have been resolved. Thank you!

@floatpanebot

Copy link
Copy Markdown
Member

Benchmark report — no significant change

Metrics worse: 0 · better: 0 (threshold: ±3%).

benchstat output
goos: linux
goarch: amd64
pkg: github.com/floatpane/matcha/backend
cpu: AMD EPYC 9V74 80-Core Processor                
                           │   old.txt    │               new.txt               │
                           │    sec/op    │    sec/op      vs base              │
ParseSearchQuery_Simple-4    2.204µ ± 20%   2.589µ ±  27%       ~ (p=0.310 n=6)
ParseSearchQuery_Complex-4   6.961µ ± 79%   5.143µ ±  97%       ~ (p=0.240 n=6)
TokenizeSearchQuery-4        4.141µ ± 42%   4.492µ ± 211%       ~ (p=0.485 n=6)
geomean                      3.990µ         3.911µ         -1.99%

                           │  old.txt   │              new.txt               │
                           │    B/op    │    B/op     vs base                │
ParseSearchQuery_Simple-4    26.00 ± 0%   26.00 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   762.0 ± 0%   762.0 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        176.0 ± 0%   176.0 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      151.6        151.6       +0.00%
¹ all samples are equal

                           │  old.txt   │              new.txt               │
                           │ allocs/op  │ allocs/op   vs base                │
ParseSearchQuery_Simple-4    2.000 ± 0%   2.000 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   23.00 ± 0%   23.00 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        9.000 ± 0%   9.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      7.453        7.453       +0.00%
¹ all samples are equal

pkg: github.com/floatpane/matcha/tui
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
LogPanelView-4        160.4µ ±  9%   163.6µ ±  6%       ~ (p=0.699 n=6)
SearchOverlayView-4   177.4µ ± 11%   172.6µ ±  7%       ~ (p=0.394 n=6)
InboxConstruction-4   988.2µ ± 16%   890.1µ ± 17%       ~ (p=0.132 n=6)
geomean               304.1µ         292.9µ        -3.68%

                    │    old.txt    │               new.txt               │
                    │     B/op      │     B/op       vs base              │
LogPanelView-4        44.67Ki ± 51%   44.67Ki ±  0%       ~ (p=0.455 n=6)
SearchOverlayView-4   56.14Ki ± 41%   44.66Ki ± 26%       ~ (p=0.805 n=6)
InboxConstruction-4   874.3Ki ±  0%   874.3Ki ±  0%       ~ (p=0.729 n=6)
geomean               129.9Ki         120.4Ki        -7.34%

                    │   old.txt   │              new.txt              │
                    │  allocs/op  │  allocs/op   vs base              │
LogPanelView-4         714.0 ± 0%    714.0 ± 0%       ~ (p=0.455 n=6)
SearchOverlayView-4    926.0 ± 0%    925.0 ± 0%       ~ (p=1.000 n=6)
InboxConstruction-4   3.478k ± 0%   3.478k ± 0%       ~ (p=0.584 n=6)
geomean               1.320k        1.319k       -0.04%

auto-generated by benchmarks.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Configuration / settings area/oauth OAuth / XOAUTH2 / auth flows bug Something isn't working documentation Documentation changes os/windows Windows-specific size/S Diff: 11–50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.