Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

improved print CSS for fish_config#9828

Merged
faho merged 2 commits into
fish-shell:masterfish-shell/fish-shell:masterfrom
korve:masterkorve/fish-shell:masterCopy head branch name to clipboard
Jun 10, 2023
Merged

improved print CSS for fish_config#9828
faho merged 2 commits into
fish-shell:masterfish-shell/fish-shell:masterfrom
korve:masterkorve/fish-shell:masterCopy head branch name to clipboard

Conversation

@korve

@korve korve commented Jun 2, 2023

Copy link
Copy Markdown

Description

This commit introduces a fishconfig_print.css that contains special CSS styles that only apply when printing the fishconfig page. This is especially useful when the user wants to print out the key bindings.

Also the filter input is now hidden when printing any of the tabs on the config page.

Before:

before

After:

after

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

Andre Eckardt added 2 commits June 2, 2023 14:07
This commit introduces a fishconfig_print.css that contains special CSS styles that only apply when printing the fishconfig page. This is especially useful when the user wants to print out the key bindings.
@Xiretza

Xiretza commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

The result looks great! Something that would probably be good for the regular stylesheet as well: could the right column's width be reduced to fit as much of the left column as possible, rather than always splitting the page in the middle? The bindings are almost always longer than the key sequences.

@korve

korve commented Jun 5, 2023

Copy link
Copy Markdown
Author

The result looks great! Something that would probably be good for the regular stylesheet as well: could the right column's width be reduced to fit as much of the left column as possible, rather than always splitting the page in the middle? The bindings are almost always longer than the key sequences.

Its kinda difficult to find a width for every screen/orientation so the right column doesn't get too small. Also, you can expand rows when clicking on them, so more content is revealed on the right column.

Some keys are really weird, for example commandline\ -f\ expand-abbr\;\ commandline\ -i\ \\n. What does it even do? Maybe more descriptive keys would be a better solution?

@faho
faho merged commit cbf9a3b into fish-shell:master Jun 10, 2023
@faho faho added this to the fish 3.6.2 milestone Jun 10, 2023
@faho

faho commented Jun 10, 2023

Copy link
Copy Markdown
Member

Merged, thanks!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.