Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add completion for kind#9110

Closed
kfkonrad wants to merge 2 commits into
fish-shell:masterfish-shell/fish-shell:masterfrom
kfkonrad:feature/add-kind-completionkfkonrad/fish-shell:feature/add-kind-completionCopy head branch name to clipboard
Closed

add completion for kind#9110
kfkonrad wants to merge 2 commits into
fish-shell:masterfish-shell/fish-shell:masterfrom
kfkonrad:feature/add-kind-completionkfkonrad/fish-shell:feature/add-kind-completionCopy head branch name to clipboard

Conversation

@kfkonrad

@kfkonrad kfkonrad commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

Description

This PR adds completion for kind (Kubernetes in Docker)

Since kind can generate its own completions we'll simply use that.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@kfkonrad
kfkonrad force-pushed the feature/add-kind-completion branch from 1e0636b to f36cf99 Compare August 5, 2022 13:25
@krobelus krobelus closed this in 6128b58 Aug 9, 2022
@krobelus

krobelus commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

sounds reasonable, merged as 6128b58, thanks!

@krobelus krobelus added this to the fish 3.6.0 milestone Aug 9, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.