Improve the size of completions page to show the entire multi-line prompt#4702
Closed
s417-lama wants to merge 1 commit into
fish-shell:masterfish-shell/fish-shell:masterfrom
s417-lama:improve_completions_page_sizes417-lama/fish-shell:improve_completions_page_sizeCopy head branch name to clipboard
Closed
Improve the size of completions page to show the entire multi-line prompt#4702s417-lama wants to merge 1 commit intofish-shell:masterfish-shell/fish-shell:masterfrom s417-lama:improve_completions_page_sizes417-lama/fish-shell:improve_completions_page_sizeCopy head branch name to clipboard
s417-lama wants to merge 1 commit into
fish-shell:masterfish-shell/fish-shell:masterfrom
s417-lama:improve_completions_page_sizes417-lama/fish-shell:improve_completions_page_sizeCopy head branch name to clipboard
Conversation
Member
|
Thanks, nice fix! I'm going to merge it as is, but then I will change it to use a simple newline count instead of the heavyweight prompt layout machinery. Merged as 27c1c06 - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
When editing multi lines and selecting completions, the page of completions hides the lines except the bottom line.
I think it is uncomfortable not to be able to see the entire lines even after selecting the completion.
What I changed
I changed to show the entire lines when selecting completions.
TODOs: