reader: Apply fish_color_selection fg color and options in vi visual mode#9717
Merged
ridiculousfish merged 1 commit intoApr 9, 2023
fish-shell:masterfish-shell/fish-shell:masterfrom
ericvw:fish_color_selection-respect-fgericvw/fish-shell:fish_color_selection-respect-fgCopy head branch name to clipboard
Merged
reader: Apply fish_color_selection fg color and options in vi visual mode#9717ridiculousfish merged 1 commit intofish-shell:masterfish-shell/fish-shell:masterfrom ericvw:fish_color_selection-respect-fgericvw/fish-shell:fish_color_selection-respect-fgCopy head branch name to clipboard
ridiculousfish merged 1 commit into
fish-shell:masterfish-shell/fish-shell:masterfrom
ericvw:fish_color_selection-respect-fgericvw/fish-shell:fish_color_selection-respect-fgCopy head branch name to clipboard
Conversation
…mode Vi visual mode selection highlighting behaves unexpectedly when the selection foreground and background in the highlight spec don't match. The following unexpected behaviors are: * The foreground color is not being applied when defined by the `fish_color_selection` variable. * `set_color` options (e.g., `--bold`) would not be applied under the cursor when selection begins in the middle of the command line or when the cursor moves forward after visually selecting text backward. With this change, visual selection respects the foreground color and any `set_color` options are applied consistently regardless of where visual selection begins and the position of the cursor during selection.
Member
|
Thank you! Very well found for a first contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Vi visual mode selection highlighting behaves unexpectedly when the selection
foreground and background in the highlight spec don't match. The following
unexpected behaviors are:
fish_color_selectionvariable.set_coloroptions (e.g.,--bold) would not be applied under the cursorwhen selection begins in the middle of the command line or when the cursor
moves forward after visually selecting text backward.
With this change, visual selection respects the foreground color and any
set_coloroptions are applied consistently regardless of where visualselection begins and the position of the cursor during selection.
TODOs: