Replicate upstream git logic for alias commands#8129
Merged
faho merged 1 commit intoJul 12, 2021
fish-shell:masterfish-shell/fish-shell:masterfrom
rocketraman:git-alias-command-extractionrocketraman/fish-shell:git-alias-command-extractionCopy head branch name to clipboard
Merged
Replicate upstream git logic for alias commands#8129faho merged 1 commit intofish-shell:masterfish-shell/fish-shell:masterfrom rocketraman:git-alias-command-extractionrocketraman/fish-shell:git-alias-command-extractionCopy head branch name to clipboard
faho merged 1 commit into
fish-shell:masterfish-shell/fish-shell:masterfrom
rocketraman:git-alias-command-extractionrocketraman/fish-shell:git-alias-command-extractionCopy head branch name to clipboard
Conversation
faho
reviewed
Jul 11, 2021
rocketraman
force-pushed
the
git-alias-command-extraction
branch
from
July 12, 2021 12:56
4df3542 to
e184f1e
Compare
Contributor
Author
|
@faho I've updated the link to the git repo to point to a specific commit. Let me know what else I should do here. I'm using this locally and getting significantly better git alias completion in fish. |
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This (partially) replicates the git upstream logic for extracting a git command from a git alias. Currently fish ignores all aliases that start with
!-- we now attempt to parse these instead.Fixes issue #3954.
TODOs: