Add color to ls output on OpenBSD when colorls is installed#8035
Conversation
|
Alright, updated to use |
|
Is "colorls" here referring to https://github.com/athityakumar/colorls? I believe that is essentially obsolete when things like exa or lsd exist as much faster alternatives. Or does openbsd have some other program called colorls? |
|
And this is the man page: |
|
Merged, thanks! |
|
You beat me to one more fix I was working on: https://github.com/bonds/fish-shell/commit/fd228351a9254ff9d97232dca42d7bcfb870330a Should I open a new PR for that? |
Nah, cherry-picked as ad38730. |
|
@IlanCosman I'm thinking about the same thing. What if people has https://github.com/athityakumar/colorls in path? I tried installing |
|
Hmm. Well, in a previous version of this PR I tested the chosen ls command with different parameters to check that they were at least supported...that would avoid this problem. I didn't keep that version because @faho didn't like the global function I wrote to reuse my check for colorls's existence, but perhaps a version that does the same thing without a global function would be good. |
|
Fixed in a633889, we now ignore a "colorls" if it doesn't understand "-F". Which ignores the ruby colorls, but that seems to be closer in spirit to exa than normal ls. |
|
Thanks @faho ! |
Description
Adds color to ls output on OpenBSD when colorls is installed.
Fixes issue #
TODOs: