Add completions for yadm#7100
Merged
krobelus merged 3 commits intoJun 30, 2020
fish-shell:masterfish-shell/fish-shell:masterfrom
sudormrfbin:add-yadm-completionssudormrfbin/fish-shell:add-yadm-completionsCopy head branch name to clipboard
Merged
Add completions for yadm#7100krobelus merged 3 commits intofish-shell:masterfish-shell/fish-shell:masterfrom sudormrfbin:add-yadm-completionssudormrfbin/fish-shell:add-yadm-completionsCopy head branch name to clipboard
krobelus merged 3 commits into
fish-shell:masterfish-shell/fish-shell:masterfrom
sudormrfbin:add-yadm-completionssudormrfbin/fish-shell:add-yadm-completionsCopy head branch name to clipboard
Conversation
faho
reviewed
Jun 14, 2020
sudormrfbin
force-pushed
the
add-yadm-completions
branch
from
June 19, 2020 05:29
8436f19 to
c4d1b2c
Compare
Contributor
Author
|
The completions have been finished and now react to |
faho
reviewed
Jun 20, 2020
krobelus
reviewed
Jun 21, 2020
| # See `yadm gitconfig` for setting git config values | ||
| function __fish_yadm_config_keys | ||
| yadm introspect configs | ||
| end |
Contributor
There was a problem hiding this comment.
I guess this function could now be inlined, whatever you prefer.
Contributor
Author
There was a problem hiding this comment.
I think I'll leave it as is, because __fish_yadm_config_keys seems more readable and intuitive to me than yadm introspect configs
sudormrfbin
force-pushed
the
add-yadm-completions
branch
from
June 21, 2020 13:35
cd98827 to
3cf3433
Compare
Contributor
|
Thanks and sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add completions for yadm. It's wraps around git and all of git's features are usable.
TODOs:
clonesubcommand as yadm hasclonewith different optionsyadm gitconfigshould inherit completions fromgit config--yadm-repooptionI'm not sure if suppressing inherited completions for specific options is possible or not, so could use a pointer.