Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Option to disable private mode message #6299

Copy link
Copy link

Description

@teake
Issue body actions

Hi, first time issue poster here. First off, thanks for developing fish. It's awesome!

I've recently discovered private mode, and it looks very useful for screencasts with asciinema. However, when I start a recording with asciinema rec -c 'fish --private' the private mode prints the message:

.
fish is running in private mode, history will not be persisted.

The first line is a bug when the greeting message is empty. This is handled correctly in

if status --is-interactive
if functions -q fish_greeting
fish_greeting
else
# The greeting used to be skipped when fish_greeting was empty (not just undefined)
# Keep it that way to not print superfluous newlines on old configuration
test -n "$fish_greeting"
and echo $fish_greeting
end
end

but not in
if set -q fish_private_mode
set -l line (_ "fish is running in private mode, history will not be persisted.")
set -g fish_greeting $fish_greeting.\n$line
end

But the reason I'm posting this issue is that I would like an option to remove the private mode message altogether, so that it doesn't show up in a screencast. Perhaps something like mechanism for the normal greeting message, http://fishshell.com/docs/current/faq.html#faq-greeting?

Btw, I'm running fish 3.0.2 on macOS 10.14.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething that's not working as intendedSomething that's not working as intended

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.