systemctl completions: Add missing fix for .device/etc#1972
Closed
faho wants to merge 13 commits into
Closed
systemctl completions: Add missing fix for .device/etc#1972faho wants to merge 13 commits into
faho wants to merge 13 commits into
Conversation
This fixes completions for e.g. `systemctl --quiet status`
It should now support all unit types mentioned in systemd.unit(5)
Inspired by the official bash completion, this uses systemd --dump-configuration-items.
For-loops ftw!
Was single-quoted, should have been double-quoted
This includes only showing unmasked units in mask, only loaded units in start and more types in show/list-dependencies
Unfortunately, list-unit-files doesn't understand --state=loaded This needs a new function to explicitly use list-units This reverts commit 9f521b7.
A rogue single-quote meant that a non-existent function '__fish_systemctl_$t' was called
Member
|
Cherry-picked as 22103e4 - thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately a typo got through in my last PR which caused .device/.swap/.scope/.slice completion to not take place even for the subcommands for which we tried to enable it.
Also unfortunately, github seems to not be able to figure out that all I want pulled is 12416ec since the rest already is.
Sorry for the annoyance.