Remove the actual email value from the error message returned by validateEmail()#587
Open
pepnova-9 wants to merge 1 commit into
firebase:devfirebase/firebase-admin-go:devfrom
pepnova-9:feat/fix-validate-email-error-messagepepnova-9/firebase-admin-go:feat/fix-validate-email-error-messageCopy head branch name to clipboard
Open
Remove the actual email value from the error message returned by validateEmail()#587pepnova-9 wants to merge 1 commit intofirebase:devfirebase/firebase-admin-go:devfrom pepnova-9:feat/fix-validate-email-error-messagepepnova-9/firebase-admin-go:feat/fix-validate-email-error-messageCopy head branch name to clipboard
pepnova-9 wants to merge 1 commit into
firebase:devfirebase/firebase-admin-go:devfrom
pepnova-9:feat/fix-validate-email-error-messagepepnova-9/firebase-admin-go:feat/fix-validate-email-error-messageCopy head branch name to clipboard
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
CLA signed |
pepnova-9
force-pushed
the
feat/fix-validate-email-error-message
branch
from
September 28, 2023 00:19
2c6c781 to
19d7134
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes #586.
This is one of my suggestions that I have provided in the above issue. I believe that no one parses and utilizes the error message returned by the validateEmail() function. If there are any considerations I need to be aware of, please let me know.
RELEASE NOTE: Remove the actual email value passed as an argument from the error message returned by validateEmail().