Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enable deep linking for video search and tags#231

Merged
jmasessa merged 1 commit into
mainfinos/zenith:mainfrom
psmulovics/video-deep-linkingfinos/zenith:psmulovics/video-deep-linkingCopy head branch name to clipboard
Jul 16, 2026
Merged

Enable deep linking for video search and tags#231
jmasessa merged 1 commit into
mainfinos/zenith:mainfrom
psmulovics/video-deep-linkingfinos/zenith:psmulovics/video-deep-linkingCopy head branch name to clipboard

Conversation

@psmulovics

Copy link
Copy Markdown
Contributor

Why

Video library filters were local-only, so selected tags and search text could not be shared via URL, and browser back/forward did not restore filter state.

What changed

  • Initialize video filter state from URL query params on page load.
  • Persist filter changes to the URL using search (text query) and tags (comma-separated categories).
  • Listen to browser popstate so back/forward navigation restores search and tag selections.
  • Update clear-filter behavior to clear all selected tags in one state update and one history entry.

Notes for reviewers

  • Tag values are validated against supported categories before applying from URL.
  • Tags are sorted before writing to the URL to keep deep links stable.

Sync video search and tag filters with URL query params, and restore state on browser back/forward navigation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 16, 2026 21:49
@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for exquisite-bubblegum-0fc485 ready!

Name Link
🔨 Latest commit 7d84fea
🔍 Latest deploy log https://app.netlify.com/projects/exquisite-bubblegum-0fc485/deploys/6a5951f24081ca00083cf478
😎 Deploy Preview https://deploy-preview-231--exquisite-bubblegum-0fc485.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds URL-based deep linking for the Video Library’s filters so that search text and selected tags can be shared via the URL and restored via browser navigation.

Changes:

  • Initialize search and tags filter state from URL query params on page load.
  • Persist filter changes back to the URL, including sorting tags for stable deep links.
  • Add popstate handling and simplify “Clear Filters” to clear selected tags in a single state update.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
website/src/components/VideoPlayer/VideoPlayer.jsx Adds URL parsing/serialization for search and tags, plus popstate restoration and clear-tag handler.
website/src/components/VideoPlayer/FilterBar.jsx Wires the “Clear Filters” button to a dedicated clear handler instead of toggling each tag individually.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread website/src/components/VideoPlayer/VideoPlayer.jsx
@jmasessa
jmasessa merged commit d798d54 into main Jul 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.