Autocomplete member selectivity#607
Open
Declspeck wants to merge 40 commits into
felixfbecker:masterfelixfbecker/php-language-server:masterfrom
Declspeck:autocomplete-member-selectivityDeclspeck/php-language-server:autocomplete-member-selectivityCopy head branch name to clipboard
Open
Autocomplete member selectivity#607Declspeck wants to merge 40 commits intofelixfbecker:masterfelixfbecker/php-language-server:masterfrom Declspeck:autocomplete-member-selectivityDeclspeck/php-language-server:autocomplete-member-selectivityCopy head branch name to clipboard
Declspeck wants to merge 40 commits into
felixfbecker:masterfelixfbecker/php-language-server:masterfrom
Declspeck:autocomplete-member-selectivityDeclspeck/php-language-server:autocomplete-member-selectivityCopy head branch name to clipboard
Conversation
This reverts commit 48bbbb5.
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
============================================
+ Coverage 81.63% 81.94% +0.31%
- Complexity 910 947 +37
============================================
Files 61 61
Lines 2075 2227 +152
============================================
+ Hits 1694 1825 +131
- Misses 381 402 +21
|
Owner
|
Is this still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes completions for
TestClass::SOMETHING_ELSEwhen completing forTestClass::NOT_SOMETHING_ELS|. Same for->completions.This is based on #599 so this cannot be merged before that, and only the last commit contains any meaningful changes.