Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

NYC sample notebook feature re-name#991

Merged
blrchen merged 2 commits into
feathr-ai:mainfeathr-ai/feathr:mainfrom
loomlike:jumin/f_trip_speedloomlike/feathr:jumin/f_trip_speedCopy head branch name to clipboard
Jan 19, 2023
Merged

NYC sample notebook feature re-name#991
blrchen merged 2 commits into
feathr-ai:mainfeathr-ai/feathr:mainfrom
loomlike:jumin/f_trip_speedloomlike/feathr:jumin/f_trip_speedCopy head branch name to clipboard

Conversation

@loomlike
Copy link
Copy Markdown
Collaborator

Description

To make the feature name more straightforward: f_trip_time_distance --> f_trip_speed.

How was this PR tested?

Notebook pytest

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@loomlike loomlike requested a review from blrchen January 18, 2023 17:29
@loomlike loomlike added the safe to test Tag to execute build pipeline for a PR from forked repo label Jan 18, 2023
@blrchen
Copy link
Copy Markdown
Collaborator

blrchen commented Jan 19, 2023

@xiaoyongzhu do you still have the raw content for the image used in nyc taxi notebook? So we can update the image as well

@loomlike
Copy link
Copy Markdown
Collaborator Author

@blrchen I did update the image that's included in this PR.

@blrchen blrchen merged commit d869dd3 into feathr-ai:main Jan 19, 2023
xiaoyongzhu added a commit to xiaoyongzhu/feathr that referenced this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Tag to execute build pipeline for a PR from forked repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.