Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Lock python deps versions in sql registry#977

Merged
xiaoyongzhu merged 1 commit into
mainfeathr-ai/feathr:mainfrom
blair/update-depsfeathr-ai/feathr:blair/update-depsCopy head branch name to clipboard
Jan 17, 2023
Merged

Lock python deps versions in sql registry#977
xiaoyongzhu merged 1 commit into
mainfeathr-ai/feathr:mainfrom
blair/update-depsfeathr-ai/feathr:blair/update-depsCopy head branch name to clipboard

Conversation

@blrchen
Copy link
Copy Markdown
Collaborator

@blrchen blrchen commented Jan 17, 2023

Description

This PR locks pip version for a few recent new deps

  • cython: according to @enya-yx , this is required for sql registry to work on her dev environment, use latest version
  • pydantic: removed, this is an indirect dep consumed by fastapi.
  • sqlalchemy: this is newly added by @xiaoyongzhu for sandbox support, use latest version.

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@xiaoyongzhu xiaoyongzhu merged commit 2c87b8a into main Jan 17, 2023
@blrchen blrchen deleted the blair/update-deps branch January 17, 2023 14:55
xiaoyongzhu added a commit to xiaoyongzhu/feathr that referenced this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.