Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix auto-tz casting bug#905

Merged
bozhonghu merged 1 commit into
feathr-ai:mainfeathr-ai/feathr:mainfrom
bozhonghu:fix_auto_tz_bugbozhonghu/feathr:fix_auto_tz_bugCopy head branch name to clipboard
Dec 15, 2022
Merged

Fix auto-tz casting bug#905
bozhonghu merged 1 commit into
feathr-ai:mainfeathr-ai/feathr:mainfrom
bozhonghu:fix_auto_tz_bugbozhonghu/feathr:fix_auto_tz_bugCopy head branch name to clipboard

Conversation

@bozhonghu
Copy link
Copy Markdown
Collaborator

Description

Fix auto-tz casting bug. The original code was unable to handle primitive arrays, i.e. int[] and would throw an error Caused by: java.lang.ClassCastException: [I cannot be cast to [Ljava.lang.Object; when encountering int[]. This specifically can cause an issue when trying to use auto-tz to convert from an array of floats to

 type: {
        type: TENSOR
        tensorCategory: SPARSE
        dimensionType: [INT]
        valType: FLOAT
      }

Changing it to use toArray resolves this issue.

How was this PR tested?

Added a new test case within integ test

Does this PR introduce any user-facing changes?

No

@bozhonghu bozhonghu merged commit 8c8f667 into feathr-ai:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.