Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

UI: Display feature key column in feature table#569

Merged
xiaoyongzhu merged 3 commits into
mainfeathr-ai/feathr:mainfrom
blair/add-key-columnfeathr-ai/feathr:blair/add-key-columnCopy head branch name to clipboard
Aug 11, 2022
Merged

UI: Display feature key column in feature table#569
xiaoyongzhu merged 3 commits into
mainfeathr-ai/feathr:mainfrom
blair/add-key-columnfeathr-ai/feathr:blair/add-key-columnCopy head branch name to clipboard

Conversation

@blrchen
Copy link
Copy Markdown
Collaborator

@blrchen blrchen commented Aug 10, 2022

Description

This PR updates UI feature table to display feature key columns.

How was this patch tested?

Verified feature key can be displayed correctly in feature table
image

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • [x ] Yes. Make sure to clarify your proposed changes.

@xiaoyongzhu
Copy link
Copy Markdown
Member

Thanks! LGTM

xiaoyongzhu
xiaoyongzhu previously approved these changes Aug 10, 2022
Comment thread .github/pull_request_template.md
@xiaoyongzhu xiaoyongzhu merged commit ee90093 into main Aug 11, 2022
@blrchen blrchen deleted the blair/add-key-column branch August 11, 2022 08:27
ahlag pushed a commit to ahlag/feathr that referenced this pull request Aug 26, 2022
* Add key column in feature list page

* Fix lint issues

* Change Key to Entity Key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.