Revert "Add retry when data loading fails (#930)"#1021
Merged
xiaoyongzhu merged 1 commit intoJan 30, 2023
feathr-ai:mainfeathr-ai/feathr:mainfrom
jaymo001:revertMissingDataRetryjaymo001/feathr:revertMissingDataRetryCopy head branch name to clipboard
Merged
Revert "Add retry when data loading fails (#930)"#1021xiaoyongzhu merged 1 commit intofeathr-ai:mainfeathr-ai/feathr:mainfrom jaymo001:revertMissingDataRetryjaymo001/feathr:revertMissingDataRetryCopy head branch name to clipboard
xiaoyongzhu merged 1 commit into
feathr-ai:mainfeathr-ai/feathr:mainfrom
jaymo001:revertMissingDataRetryjaymo001/feathr:revertMissingDataRetryCopy head branch name to clipboard
Conversation
This reverts commit dce3766.
rakeshkashyap123
approved these changes
Jan 30, 2023
xiaoyongzhu
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit dce3766.
Description
Reverting the missing data retry as it may increase 'time-to-fail' and success of retry resolving actual upstream data issue could be remote. We will add an option to skip missing feature instead of fail the job.