warning if event handlers already registered or has weird argspec

fastplotlib · kushalkolar · Dec 23, 2022 · Dec 19, 2022 · Dec 19, 2022 · Dec 19, 2022
commit 22f72834da5fd3d66205c54b572676ca51ae18e3
diff --git a/fastplotlib/graphics/features/_base.py b/fastplotlib/graphics/features/_base.py
@@ -1,5 +1,6 @@
 from abc import ABC, abstractmethod
 from inspect import getfullargspec
+from warnings import warn
 from typing import *

 import numpy as np
@@ -63,6 +64,11 @@ def add_event_handler(self, handler: callable):
        """
        if not callable(handler):
            raise TypeError("event handler must be callable")
+
+        if handler in self._event_handlers:
+            warn(f"Event handler {handler} is already registered.")
+            return
+
        self._event_handlers.append(handler)

    #TODO: maybe this can be implemented right here in the base class
@@ -73,7 +79,11 @@ def _feature_changed(self, key: Union[int, slice, Tuple[slice]], new_data: Any):

    def _call_event_handlers(self, event_data: FeatureEvent):
        for func in self._event_handlers:
-            if len(getfullargspec(func).args) > 0:
+            try:
+                if len(getfullargspec(func).args) > 0:
+                    func(event_data)
+            except:
+                warn(f"Event handler {func} has an unresolvable argspec, trying it anyways.")
                func(event_data)
            else:
                func()