Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

indexable graphic attributes#78

Merged
kushalkolar merged 11 commits intomasterfastplotlib/fastplotlib:masterfrom
graphic-attrsfastplotlib/fastplotlib:graphic-attrsCopy head branch name to clipboard
Dec 23, 2022
Merged

indexable graphic attributes#78
kushalkolar merged 11 commits intomasterfastplotlib/fastplotlib:masterfrom
graphic-attrsfastplotlib/fastplotlib:graphic-attrsCopy head branch name to clipboard

Conversation

@kushalkolar
Copy link
Copy Markdown
Member

@kushalkolar kushalkolar commented Dec 19, 2022

implements #77

GraphicFeatures to implement:

  • colors
  • sizes
  • data - mostly wrap current update_data methods, just pass the slice obj directly to geo.grid or geo.positions, and for positions update_range with indices parsed by slice object, otherwise entire thing with grid.
  • present (different from visibility) - not indexable
  • events for when these change

@kushalkolar
Copy link
Copy Markdown
Member Author

color indexing is really nice :D

crazy_colors-2022-12-19_04.30.30.mp4

@kushalkolar
Copy link
Copy Markdown
Member Author

this insanity is possible now: https://www.youtube.com/watch?v=j_gwi-Wf1Ao

also this which is more useful 😄

image

@kushalkolar
Copy link
Copy Markdown
Member Author

For scatter we can make size an indexable feature too.

@kushalkolar kushalkolar mentioned this pull request Dec 22, 2022
14 tasks
@kushalkolar
Copy link
Copy Markdown
Member Author

kushalkolar commented Dec 22, 2022

@EricThomson, @clewis7 , @ArjunPutcha
guys this is pretty epic, changing a GraphicFeature can trigger events 😄

Caitlin, pick_info formatting is the same as pygfx events to make life easy :D

features-events-2022-12-22_06.07.58.mp4

Will merge as soon as #61 is ready

@EricThomson
Copy link
Copy Markdown
Contributor

Nice -- this will make certain other things so much easier.

@kushalkolar kushalkolar merged commit 088f032 into master Dec 23, 2022
@kushalkolar kushalkolar deleted the graphic-attrs branch January 7, 2023 03:22
@kushalkolar kushalkolar mentioned this pull request Jan 14, 2023
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.