Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

update contrib guide, add developer notes #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 25, 2024
Merged

update contrib guide, add developer notes #667

merged 6 commits into from
Oct 25, 2024

Conversation

clewis7
Copy link
Member

@clewis7 clewis7 commented Oct 24, 2024

supersedes #580

Because something wonky happened with the iris dataset and all of the changes with imgui, it was easier to just open a new PR for this

@clewis7 clewis7 mentioned this pull request Oct 24, 2024
5 tasks
@clewis7 clewis7 marked this pull request as ready for review October 24, 2024 15:29
@clewis7 clewis7 requested a review from kushalkolar as a code owner October 24, 2024 15:29
Copy link

github-actions bot commented Oct 24, 2024

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/contrib-guide

@kushalkolar
Copy link
Member

Some formatting issues and also add the developer docs as a separate dir, like user guide, and have a toc page with the graphics and plotarea in the toctree

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@clewis7 clewis7 merged commit 7a0e40f into main Oct 25, 2024
9 checks passed
@clewis7 clewis7 deleted the contrib-guide branch October 25, 2024 21:28
FlynnOConnell pushed a commit to FlynnOConnell/fastplotlib that referenced this pull request Jan 7, 2025
* new pr for contrib guide

* fix warning

* fix formatting issues

* reformat

* Update docs/source/developer_notes/graphics.rst

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.