Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

update contributing guide #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

update contributing guide #580

wants to merge 9 commits into from

Conversation

clewis7
Copy link
Member

@clewis7 clewis7 commented Aug 5, 2024 •
edited
Loading

Start to update the contributing guide

  • more detailed instructions on contributing
  • move specific information about fpl API to developer notes section in the docs
    • graphics
    • graphic features
    • layouts

will wait to add developer notes for other parts of the API later when they are more stable

@clewis7 clewis7 marked this pull request as ready for review September 17, 2024 16:26
kushalkolar
kushalkolar requested changes Sep 17, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@clewis7 clewis7 marked this pull request as draft September 27, 2024 18:51
kushalkolar
kushalkolar requested changes Sep 29, 2024
View reviewed changes
Copy link
Member

@kushalkolar kushalkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few very minor things and then good to go! 🥳

docs/source/developer_notes/graphics.rst Show resolved Hide resolved
docs/source/developer_notes/graphics.rst Show resolved Hide resolved
docs/source/developer_notes/graphics.rst Show resolved Hide resolved
docs/source/developer_notes/graphics.rst Show resolved Hide resolved
docs/source/developer_notes/graphics.rst Show resolved Hide resolved
docs/source/developer_notes/layouts.rst Show resolved Hide resolved
docs/source/developer_notes/layouts.rst Show resolved Hide resolved
docs/source/developer_notes/layouts.rst Show resolved Hide resolved
docs/source/developer_notes/layouts.rst Show resolved Hide resolved
@kushalkolar kushalkolar marked this pull request as ready for review September 29, 2024 03:00
@kushalkolar
Copy link
Member

@clewis7 after addressing these and once #639 is in main we can rebase this onto main. And then what do you think about add a few base classes like Graphic, FeatureEvent, BufferManager etc to the API docs since that's useful for devs.

@clewis7 clewis7 mentioned this pull request Oct 24, 2024
Merged
@clewis7
Copy link
Member Author

clewis7 commented Oct 24, 2024

superseded by #667

@clewis7 clewis7 closed this Oct 24, 2024
@clewis7 clewis7 deleted the update_contrib branch October 24, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushalkolar kushalkolar kushalkolar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clewis7 @kushalkolar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.