Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

More controllers #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

More controllers #280

wants to merge 2 commits into from

Conversation

kushalkolar
Copy link
Member

  • adds the new controllers from pygfx:
    • panzoom
    • fly (new)
    • orbit
    • trackball (new)

works properly in simple Plot, needs more thought for GridPlot, especially considering #267

@kushalkolar kushalkolar mentioned this pull request Jul 7, 2023
@clewis7 clewis7 self-requested a review August 3, 2023 17:47
@clewis7
Copy link
Member

clewis7 commented Sep 11, 2023

I know we definitely said to default to a camera based on data dims is not given, so FlyController for 3d and Panzoom for 2d

@ArjunPutcha
Copy link
Collaborator

Controller_ID - defines controller for each subplot
number of elements must be <= number of elements in grid shape
elements in the same row belong to same controller
elements not listed are by default assigned a unique controller

Controller_type - defines type of controller for each subplot
defined upon initialization, must be same shape as grid_shape.
If not defined, default is 'panzoom' for '2d', and 'flycontroller' for '3d'
Cannot be 'partially' defined. Either define the entire array, or none.

This is what I recall

@kushalkolar kushalkolar mentioned this pull request Sep 21, 2023
17 tasks
@kushalkolar
Copy link
Member Author

superseeded by #382

@kushalkolar kushalkolar deleted the more-controllers branch December 10, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.