Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Sync Subplots by Name #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Sync Subplots by Name #267

wants to merge 7 commits into from

Conversation

ArjunPutcha
Copy link
Collaborator

Currently only done upon initialization. Will work on making this property mutable post-initialization soon.

…tement to only check if the first element is a str: converting to array should make all elements the same type, inefficient to check all indices
@ArjunPutcha ArjunPutcha linked an issue Jun 29, 2023 that may be closed by this pull request
@kushalkolar kushalkolar requested a review from clewis7 June 29, 2023 19:17
examples/notebooks/gridplot_simple.ipynb Outdated Show resolved Hide resolved
@ArjunPutcha ArjunPutcha marked this pull request as draft June 29, 2023 19:21
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
examples/notebooks/gridplot_simple.ipynb Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
@ArjunPutcha ArjunPutcha marked this pull request as ready for review July 5, 2023 19:30
@ArjunPutcha ArjunPutcha marked this pull request as draft July 5, 2023 19:30
Copy link
Member

@clewis7 clewis7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM, maybe just add some code comments here and there so later we know what is happening

fastplotlib/layouts/_gridplot.py Outdated Show resolved Hide resolved
@kushalkolar kushalkolar mentioned this pull request Jul 7, 2023
@kushalkolar
Copy link
Member

Now that #280 exists, we're going to need to figure out how to consolidate this 😄

@ArjunPutcha
Copy link
Collaborator Author

Anything you want me to do on my end? Or will you handle it?

@kushalkolar
Copy link
Member

kushalkolar commented Jul 7, 2023 via email

@kushalkolar kushalkolar mentioned this pull request Sep 21, 2023
17 tasks
@kushalkolar
Copy link
Member

superseeded by #382

@kushalkolar kushalkolar deleted the sync_subplots_name branch December 10, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync subsets of controllers in GridPlot using subplot names
4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.