-
Notifications
You must be signed in to change notification settings - Fork 52
Sync Subplots by Name #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f controllers has list of strings
…tement to only check if the first element is a str: converting to array should make all elements the same type, inefficient to check all indices
kushalkolar
reviewed
Jun 29, 2023
clewis7
requested changes
Jun 29, 2023
kushalkolar
requested changes
Jun 30, 2023
…ame number of elements as gridplot shape.
clewis7
reviewed
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM, maybe just add some code comments here and there so later we know what is happening
Closed
Now that #280 exists, we're going to need to figure out how to consolidate this 😄 |
Anything you want me to do on my end? Or will you handle it? |
We'll have to brainstorm a bit, probably at scipy sprint?
…On Fri, Jul 7, 2023, 10:06 Arjun Putcha ***@***.***> wrote:
Anything you want me to do on my end? Or will you handle it?
—
Reply to this email directly, view it on GitHub
<#267 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHXXRAQVDV4VH6FYJ75OXLXPAJXDANCNFSM6AAAAAAZYZWKGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
superseeded by #382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only done upon initialization. Will work on making this property mutable post-initialization soon.